-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1462 - Fix minkowski sum for VPolygons #1474
#1462 - Fix minkowski sum for VPolygons #1474
Conversation
Co-Authored-By: Christian Schilling <[email protected]>
…nGuadalupe/LazySets.jl into sebastianguadalupe/1462
…nGuadalupe/LazySets.jl into sebastianguadalupe/1462
j = 1 | ||
σP = σ(N[1, 0], P) | ||
σQ = σ(N[1, 0], Q) | ||
k = findfirst(==(σP), vlistP) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VPolygon
's list of vertices here by asking the support vector, but this is very specific to polygons.
So i think a cleaner (and slightly more efficient) approach would be to get directly the corresponding index from VPolygon
's support vector function. It suffices to outsource the algorithm in https://github.com/JuliaReach/LazySets.jl/blob/master/src/VPolygon.jl#L256 to an independent helper function.
EDIT: i've opened #1482 as follow-up.
Closes #1462.