Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#600 - Specialized support function computations #1454

Merged
merged 5 commits into from
Jun 21, 2019
Merged

Conversation

schillic
Copy link
Member

@schillic schillic commented Jun 20, 2019

See #600.

julia> @btime ρ($[1., 0.], $(BallInf(zeros(2), 1.)))
  7.835 ns (0 allocations: 0 bytes)  # this branch
  87.346 ns (2 allocations: 192 bytes)  # master

@schillic schillic requested a review from mforets June 20, 2019 14:34
@mforets
Copy link
Member

mforets commented Jun 20, 2019

Cool stuff 🎉

For BallInf, a similar "trick" can be applied to the support vector: instead of using radius_hyperrectangle(H) which allocates (because it has a fill), radius_hyperrectangle(H, i) is better since it can directly use B.radius.

@schillic
Copy link
Member Author

schillic commented Jun 21, 2019

EDIT: Oh, now I see that you wrote support vector 😊

@schillic schillic merged commit 1f1cd5e into master Jun 21, 2019
@schillic schillic deleted the schillic/600 branch June 21, 2019 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants