Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1270 - AbstractZonotope interface #1443

Merged
merged 7 commits into from
Jun 18, 2019
Merged

#1270 - AbstractZonotope interface #1443

merged 7 commits into from
Jun 18, 2019

Conversation

schillic
Copy link
Member

@schillic schillic commented Jun 15, 2019

Closes #1270.

I renamed generators to genmat (because it returned the matrix; I found it more natural that generators becomes an iterator over the generators).

Task list for a follow-up issue:

  • do not create zero generators in LineSegment (check identity of vertices) and AbstractHyperrectangle (check for zero entries in radius_hyperrectangle) EDIT: I added it here to have a more consistent state
  • generalize Zonotope methods to AbstractZonotope (should be possible in most places)

@schillic schillic requested a review from mforets June 15, 2019 16:45
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I left some comment regarding improving the docs, and a possible change in the way HyperrectangleGeneratorInterface is implemented.

docs/src/lib/interfaces.md Show resolved Hide resolved
src/AbstractHyperrectangle.jl Outdated Show resolved Hide resolved
src/AbstractHyperrectangle.jl Outdated Show resolved Hide resolved
src/AbstractHyperrectangle.jl Outdated Show resolved Hide resolved
src/AbstractHyperrectangle.jl Outdated Show resolved Hide resolved
src/AbstractHyperrectangle.jl Outdated Show resolved Hide resolved
src/AbstractZonotope.jl Show resolved Hide resolved
@schillic schillic requested a review from mforets June 17, 2019 21:18
@schillic schillic removed the request for review from mforets June 18, 2019 05:49
@schillic schillic merged commit 0219df2 into master Jun 18, 2019
@schillic schillic deleted the schillic/1270 branch June 18, 2019 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AbstractZonotope interface
2 participants