-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1383 - Convex hull of a triangle #1411
#1383 - Convex hull of a triangle #1411
Conversation
LGTM. Can you please add a unit test for the new special case? On a separate note, seems reasonable to add here a robust check too (for another PR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good code-style-wise but I think there are some problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some documentation of the algorithm? It can be a comment for _three_points_2d!
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Have we actually evaluated whether this implementation is faster? |
I tried it, it was ~7x faster than the default algorithm. |
…d Polyhedron Squashed commit of the following: commit ac50169 Author: Unknown <[email protected]> Date: Sat Jun 15 17:40:24 2019 +1000 added one more test for old overapproximate of lazy intersection commit 509b7f8 Author: Unknown <[email protected]> Date: Sat Jun 15 04:08:49 2019 +1000 added using project commit 795f593 Author: Unknown <[email protected]> Date: Sat Jun 15 03:46:50 2019 +1000 fixed tests commit b722c3c Author: Unknown <[email protected]> Date: Fri Jun 14 19:01:32 2019 +1000 small refactoring in unit_overapproximate commit 89fe48f Merge: 8f6f735 a5545ae Author: Unknown <[email protected]> Date: Fri Jun 14 16:29:31 2019 +1000 Merge remote-tracking branch 'origin/master' into kostemkin/1041_new commit 8f6f735 Author: Unknown <[email protected]> Date: Fri Jun 14 16:28:19 2019 +1000 fixed tests commit 8448622 Author: Unknown <[email protected]> Date: Fri Jun 14 14:38:23 2019 +1000 try to push the test commit a5545ae Author: Marcelo Forets <[email protected]> Date: Thu Jun 13 15:15:09 2019 -0300 Update Project.toml (#1437) commit 9dd9cc9 Author: Marcelo Forets <[email protected]> Date: Thu Jun 13 13:41:53 2019 -0300 Pr/1408 (#1433) * Add TaylorModels optional requirement * Linear case * Nonlinear case commit 413743e Author: Unknown <[email protected]> Date: Fri Jun 14 01:39:07 2019 +1000 fixed tests commit 47f9226 Author: Unknown <[email protected]> Date: Thu Jun 13 16:54:11 2019 +1000 added new tests for decomposed overapproximate and minor refactoring commit a7e8305 Author: Sebastián Guadalupe <[email protected]> Date: Wed Jun 12 18:29:49 2019 -0300 remove redundant vertices of LinearMap (#1428) commit c0fb6d6 Author: Unknown <[email protected]> Date: Thu Jun 13 02:58:12 2019 +1000 some code clean ups according to Christian`s comments commit 6d58c75 Merge: 02916e5 c52a2c4 Author: Christian Schilling <[email protected]> Date: Wed Jun 12 09:56:12 2019 +0200 Merge pull request #1432 from JuliaReach/schillic/times Export 'times' symbol commit c52a2c4 Author: schillic <[email protected]> Date: Wed Jun 12 08:42:55 2019 +0200 export 'times' symbol commit d70ddef Merge: 6427a29 0aa9825 Author: Unknown <[email protected]> Date: Wed Jun 12 14:18:06 2019 +1000 Merge remote-tracking branch 'origin/master' into kostemkin/1041_new commit 6427a29 Author: Unknown <[email protected]> Date: Wed Jun 12 04:03:30 2019 +1000 fixed docs commit 02916e5 Merge: 19b51ea 32a6cfa Author: Christian Schilling <[email protected]> Date: Tue Jun 11 12:17:22 2019 +0200 Merge pull request #1425 from JuliaReach/schillic/merge Simplifications in overapproximate commit b33cab8 Author: Unknown <[email protected]> Date: Tue Jun 11 20:10:58 2019 +1000 further changes in documentation and removing redundant code and comments commit 19b51ea Author: Marcelo Forets <[email protected]> Date: Tue Jun 11 06:34:19 2019 -0300 Update README.md (#1423) * Update README.md * update README and About commit 5f17132 Author: Unknown <[email protected]> Date: Tue Jun 11 15:49:43 2019 +1000 exporting common intersection preprocess part commit b965fb3 Author: Unknown <[email protected]> Date: Tue Jun 11 03:13:14 2019 +1000 export common intersection preprocess part commit 1d55f57 Author: Unknown <[email protected]> Date: Tue Jun 11 02:47:23 2019 +1000 better functions definition in docs and minor refactoring commit 77640db Author: Unknown <[email protected]> Date: Mon Jun 10 19:27:27 2019 +1000 add missing docs commit 133e962 Author: Unknown <[email protected]> Date: Mon Jun 10 18:59:09 2019 +1000 updated doc commit f67024f Author: Unknown <[email protected]> Date: Mon Jun 10 18:54:06 2019 +1000 correct import commit 8b14a4a Author: Unknown <[email protected]> Date: Mon Jun 10 18:51:16 2019 +1000 small refactoring and updated doc commit 0aa9825 Merge: 847ffe8 a56ebc3 Author: Christian Schilling <[email protected]> Date: Fri Jun 7 13:19:45 2019 +0200 Merge pull request #1426 from JuliaReach/schillic/aspectratio Set default aspect ratio in plot recipes to :none commit 06bc249 Author: Unknown <[email protected]> Date: Fri Jun 7 21:00:27 2019 +1000 refactoring to use Vector{Tuple{Int, Int}} for block indices commit a56ebc3 Author: schillic <[email protected]> Date: Fri Jun 7 07:52:54 2019 +0200 set default aspectratio in plot recipes to :none commit 32a6cfa Author: schillic <[email protected]> Date: Thu Jun 6 17:01:58 2019 +0200 simplifications in overapproximate commit 847ffe8 Merge: 2770dd6 af32212 Author: Christian Schilling <[email protected]> Date: Thu Jun 6 13:20:05 2019 +0200 Merge pull request #1414 from JuliaReach/schillic/empty_polytope_intersection Check for emptiness in concrete intersection using Polyhedra commit 2770dd6 Merge: 875ecaf 03823d1 Author: Christian Schilling <[email protected]> Date: Thu Jun 6 13:02:08 2019 +0200 Merge pull request #1419 from JuliaReach/kostemkin/1091 Decomposed linear map of CartesianProductArray commit 875ecaf Merge: 9bc6422 fd2f305 Author: Christian Schilling <[email protected]> Date: Thu Jun 6 12:26:06 2019 +0200 Merge pull request #1409 from JuliaReach/schillic/378 #378 - Add isapprox between sets commit 03823d1 Author: Unknown <[email protected]> Date: Thu Jun 6 18:15:10 2019 +1000 updated tests due to sparse commit 9b8f5be Author: Unknown <[email protected]> Date: Thu Jun 6 18:11:07 2019 +1000 Code clean up commit 16f4a71 Author: Unknown <[email protected]> Date: Thu Jun 6 16:34:15 2019 +1000 fixed tests and function signature commit 2c48134 Author: Unknown <[email protected]> Date: Thu Jun 6 16:27:08 2019 +1000 Moved intersection to overapproximation commit e20224a Author: Unknown <[email protected]> Date: Thu Jun 6 15:50:32 2019 +1000 added new tests and refactoring added functionality to keep the original structure and preallocate corresponding set commit 9bc6422 Author: Marcelo Forets <[email protected]> Date: Wed Jun 5 19:16:55 2019 -0300 Update README.md commit 617de10 Author: Sebastián Guadalupe <[email protected]> Date: Wed Jun 5 19:15:32 2019 -0300 Add three point case for concrete convex hull (#1411) commit 4221528 Merge: e517950 f1aa1ae Author: Christian Schilling <[email protected]> Date: Wed Jun 5 19:05:48 2019 +0200 Merge pull request #1415 from JuliaReach/schillic/571 #571 - Restrict iterative refinement to AbstractFloat commit f1aa1ae Author: schillic <[email protected]> Date: Fri May 31 22:13:59 2019 +0200 restrict type for iterative refinement commit 14a5980 Author: Unknown <[email protected]> Date: Wed Jun 5 20:31:08 2019 +1000 fixed is_intersection_empty to use correct projection commit 5f033d7 Author: Unknown <[email protected]> Date: Wed Jun 5 20:12:34 2019 +1000 removed redundant function commit 6b62873 Author: Unknown <[email protected]> Date: Wed Jun 5 20:08:21 2019 +1000 added correct projection commit 6160bee Author: Unknown <[email protected]> Date: Wed Jun 5 20:06:44 2019 +1000 Removed workarounds for LinearMap projection commit 9f0a8ce Author: Unknown <[email protected]> Date: Wed Jun 5 18:40:25 2019 +1000 Added tests commit a03e868 Author: Unknown <[email protected]> Date: Wed Jun 5 18:18:35 2019 +1000 Added missing is_intersection_empty functions commit 13e7b9c Author: kostakoida <[email protected]> Date: Wed Jun 5 18:00:12 2019 +1000 Update src/Approximations/overapproximate.jl Co-Authored-By: Christian Schilling <[email protected]> commit 80eed63 Author: Unknown <[email protected]> Date: Wed Jun 5 17:55:26 2019 +1000 small refactoring according to Christian's recommendations commit a66586a Author: Unknown <[email protected]> Date: Wed Jun 5 15:47:37 2019 +1000 intersection works commit ece7d74 Author: Unknown <[email protected]> Date: Wed Jun 5 05:23:36 2019 +1000 fixed tests and type instability commit 16521c3 Author: Unknown <[email protected]> Date: Wed Jun 5 05:06:09 2019 +1000 small fixes and added intersection between Cartesian products commit 54d73fd Author: Unknown <[email protected]> Date: Wed Jun 5 04:11:41 2019 +1000 updated linear map to use correct rows and updated tests commit 8742462 Author: Unknown <[email protected]> Date: Wed Jun 5 01:23:36 2019 +1000 added tests commit c7fc98d Author: Unknown <[email protected]> Date: Wed Jun 5 01:10:10 2019 +1000 cleaned up the code commit 80ab0cb Author: Unknown <[email protected]> Date: Tue Jun 4 23:43:19 2019 +1000 Correct minkowski sum addition commit e517950 Merge: 873bbf1 cfae8fd Author: Christian Schilling <[email protected]> Date: Tue Jun 4 14:11:15 2019 +0200 Merge pull request #1420 from JuliaReach/schillic/README Update README commit cfae8fd Author: schillic <[email protected]> Date: Tue Jun 4 10:42:22 2019 +0200 update README commit 5b97aec Author: Unknown <[email protected]> Date: Tue Jun 4 18:57:12 2019 +1000 small fixes commit cf01ae6 Author: Unknown <[email protected]> Date: Tue Jun 4 18:50:19 2019 +1000 updated according to comments commit 7e2891f Author: Unknown <[email protected]> Date: Tue Jun 4 17:52:32 2019 +1000 added getting block_structure for CPA and intersection by union of blocks commit a79b038 Author: Unknown <[email protected]> Date: Tue Jun 4 16:33:53 2019 +1000 added block_indices and variable_indices commit b98b789 Author: Unknown <[email protected]> Date: Tue Jun 4 16:31:30 2019 +1000 Added using @view commit ecabee5 Author: Unknown <[email protected]> Date: Tue Jun 4 14:45:14 2019 +1000 updated overaproximation of decomposed linear map according to Christian comments commit ef60e2e Author: Unknown <[email protected]> Date: Sun Jun 2 01:46:13 2019 +1000 Added overapproximation of Lazy linear map of cartesian product array commit af32212 Author: schillic <[email protected]> Date: Fri May 31 17:27:23 2019 +0200 check for emptiness in concrete intersection using Polyhedra commit fd2f305 Author: schillic <[email protected]> Date: Tue May 28 20:17:35 2019 +0200 add isapprox between 'LazySet's
…d Polyhedron Squashed commit of the following: commit ac50169 Author: Unknown <[email protected]> Date: Sat Jun 15 17:40:24 2019 +1000 added one more test for old overapproximate of lazy intersection commit 509b7f8 Author: Unknown <[email protected]> Date: Sat Jun 15 04:08:49 2019 +1000 added using project commit 795f593 Author: Unknown <[email protected]> Date: Sat Jun 15 03:46:50 2019 +1000 fixed tests commit b722c3c Author: Unknown <[email protected]> Date: Fri Jun 14 19:01:32 2019 +1000 small refactoring in unit_overapproximate commit 89fe48f Merge: 8f6f735 a5545ae Author: Unknown <[email protected]> Date: Fri Jun 14 16:29:31 2019 +1000 Merge remote-tracking branch 'origin/master' into kostemkin/1041_new commit 8f6f735 Author: Unknown <[email protected]> Date: Fri Jun 14 16:28:19 2019 +1000 fixed tests commit 8448622 Author: Unknown <[email protected]> Date: Fri Jun 14 14:38:23 2019 +1000 try to push the test commit a5545ae Author: Marcelo Forets <[email protected]> Date: Thu Jun 13 15:15:09 2019 -0300 Update Project.toml (#1437) commit 9dd9cc9 Author: Marcelo Forets <[email protected]> Date: Thu Jun 13 13:41:53 2019 -0300 Pr/1408 (#1433) * Add TaylorModels optional requirement * Linear case * Nonlinear case commit 413743e Author: Unknown <[email protected]> Date: Fri Jun 14 01:39:07 2019 +1000 fixed tests commit 47f9226 Author: Unknown <[email protected]> Date: Thu Jun 13 16:54:11 2019 +1000 added new tests for decomposed overapproximate and minor refactoring commit a7e8305 Author: Sebastián Guadalupe <[email protected]> Date: Wed Jun 12 18:29:49 2019 -0300 remove redundant vertices of LinearMap (#1428) commit c0fb6d6 Author: Unknown <[email protected]> Date: Thu Jun 13 02:58:12 2019 +1000 some code clean ups according to Christian`s comments commit 6d58c75 Merge: 02916e5 c52a2c4 Author: Christian Schilling <[email protected]> Date: Wed Jun 12 09:56:12 2019 +0200 Merge pull request #1432 from JuliaReach/schillic/times Export 'times' symbol commit c52a2c4 Author: schillic <[email protected]> Date: Wed Jun 12 08:42:55 2019 +0200 export 'times' symbol commit d70ddef Merge: 6427a29 0aa9825 Author: Unknown <[email protected]> Date: Wed Jun 12 14:18:06 2019 +1000 Merge remote-tracking branch 'origin/master' into kostemkin/1041_new commit 6427a29 Author: Unknown <[email protected]> Date: Wed Jun 12 04:03:30 2019 +1000 fixed docs commit 02916e5 Merge: 19b51ea 32a6cfa Author: Christian Schilling <[email protected]> Date: Tue Jun 11 12:17:22 2019 +0200 Merge pull request #1425 from JuliaReach/schillic/merge Simplifications in overapproximate commit b33cab8 Author: Unknown <[email protected]> Date: Tue Jun 11 20:10:58 2019 +1000 further changes in documentation and removing redundant code and comments commit 19b51ea Author: Marcelo Forets <[email protected]> Date: Tue Jun 11 06:34:19 2019 -0300 Update README.md (#1423) * Update README.md * update README and About commit 5f17132 Author: Unknown <[email protected]> Date: Tue Jun 11 15:49:43 2019 +1000 exporting common intersection preprocess part commit b965fb3 Author: Unknown <[email protected]> Date: Tue Jun 11 03:13:14 2019 +1000 export common intersection preprocess part commit 1d55f57 Author: Unknown <[email protected]> Date: Tue Jun 11 02:47:23 2019 +1000 better functions definition in docs and minor refactoring commit 77640db Author: Unknown <[email protected]> Date: Mon Jun 10 19:27:27 2019 +1000 add missing docs commit 133e962 Author: Unknown <[email protected]> Date: Mon Jun 10 18:59:09 2019 +1000 updated doc commit f67024f Author: Unknown <[email protected]> Date: Mon Jun 10 18:54:06 2019 +1000 correct import commit 8b14a4a Author: Unknown <[email protected]> Date: Mon Jun 10 18:51:16 2019 +1000 small refactoring and updated doc commit 0aa9825 Merge: 847ffe8 a56ebc3 Author: Christian Schilling <[email protected]> Date: Fri Jun 7 13:19:45 2019 +0200 Merge pull request #1426 from JuliaReach/schillic/aspectratio Set default aspect ratio in plot recipes to :none commit 06bc249 Author: Unknown <[email protected]> Date: Fri Jun 7 21:00:27 2019 +1000 refactoring to use Vector{Tuple{Int, Int}} for block indices commit a56ebc3 Author: schillic <[email protected]> Date: Fri Jun 7 07:52:54 2019 +0200 set default aspectratio in plot recipes to :none commit 32a6cfa Author: schillic <[email protected]> Date: Thu Jun 6 17:01:58 2019 +0200 simplifications in overapproximate commit 847ffe8 Merge: 2770dd6 af32212 Author: Christian Schilling <[email protected]> Date: Thu Jun 6 13:20:05 2019 +0200 Merge pull request #1414 from JuliaReach/schillic/empty_polytope_intersection Check for emptiness in concrete intersection using Polyhedra commit 2770dd6 Merge: 875ecaf 03823d1 Author: Christian Schilling <[email protected]> Date: Thu Jun 6 13:02:08 2019 +0200 Merge pull request #1419 from JuliaReach/kostemkin/1091 Decomposed linear map of CartesianProductArray commit 875ecaf Merge: 9bc6422 fd2f305 Author: Christian Schilling <[email protected]> Date: Thu Jun 6 12:26:06 2019 +0200 Merge pull request #1409 from JuliaReach/schillic/378 #378 - Add isapprox between sets commit 03823d1 Author: Unknown <[email protected]> Date: Thu Jun 6 18:15:10 2019 +1000 updated tests due to sparse commit 9b8f5be Author: Unknown <[email protected]> Date: Thu Jun 6 18:11:07 2019 +1000 Code clean up commit 16f4a71 Author: Unknown <[email protected]> Date: Thu Jun 6 16:34:15 2019 +1000 fixed tests and function signature commit 2c48134 Author: Unknown <[email protected]> Date: Thu Jun 6 16:27:08 2019 +1000 Moved intersection to overapproximation commit e20224a Author: Unknown <[email protected]> Date: Thu Jun 6 15:50:32 2019 +1000 added new tests and refactoring added functionality to keep the original structure and preallocate corresponding set commit 9bc6422 Author: Marcelo Forets <[email protected]> Date: Wed Jun 5 19:16:55 2019 -0300 Update README.md commit 617de10 Author: Sebastián Guadalupe <[email protected]> Date: Wed Jun 5 19:15:32 2019 -0300 Add three point case for concrete convex hull (#1411) commit 4221528 Merge: e517950 f1aa1ae Author: Christian Schilling <[email protected]> Date: Wed Jun 5 19:05:48 2019 +0200 Merge pull request #1415 from JuliaReach/schillic/571 #571 - Restrict iterative refinement to AbstractFloat commit f1aa1ae Author: schillic <[email protected]> Date: Fri May 31 22:13:59 2019 +0200 restrict type for iterative refinement commit 14a5980 Author: Unknown <[email protected]> Date: Wed Jun 5 20:31:08 2019 +1000 fixed is_intersection_empty to use correct projection commit 5f033d7 Author: Unknown <[email protected]> Date: Wed Jun 5 20:12:34 2019 +1000 removed redundant function commit 6b62873 Author: Unknown <[email protected]> Date: Wed Jun 5 20:08:21 2019 +1000 added correct projection commit 6160bee Author: Unknown <[email protected]> Date: Wed Jun 5 20:06:44 2019 +1000 Removed workarounds for LinearMap projection commit 9f0a8ce Author: Unknown <[email protected]> Date: Wed Jun 5 18:40:25 2019 +1000 Added tests commit a03e868 Author: Unknown <[email protected]> Date: Wed Jun 5 18:18:35 2019 +1000 Added missing is_intersection_empty functions commit 13e7b9c Author: kostakoida <[email protected]> Date: Wed Jun 5 18:00:12 2019 +1000 Update src/Approximations/overapproximate.jl Co-Authored-By: Christian Schilling <[email protected]> commit 80eed63 Author: Unknown <[email protected]> Date: Wed Jun 5 17:55:26 2019 +1000 small refactoring according to Christian's recommendations commit a66586a Author: Unknown <[email protected]> Date: Wed Jun 5 15:47:37 2019 +1000 intersection works commit ece7d74 Author: Unknown <[email protected]> Date: Wed Jun 5 05:23:36 2019 +1000 fixed tests and type instability commit 16521c3 Author: Unknown <[email protected]> Date: Wed Jun 5 05:06:09 2019 +1000 small fixes and added intersection between Cartesian products commit 54d73fd Author: Unknown <[email protected]> Date: Wed Jun 5 04:11:41 2019 +1000 updated linear map to use correct rows and updated tests commit 8742462 Author: Unknown <[email protected]> Date: Wed Jun 5 01:23:36 2019 +1000 added tests commit c7fc98d Author: Unknown <[email protected]> Date: Wed Jun 5 01:10:10 2019 +1000 cleaned up the code commit 80ab0cb Author: Unknown <[email protected]> Date: Tue Jun 4 23:43:19 2019 +1000 Correct minkowski sum addition commit e517950 Merge: 873bbf1 cfae8fd Author: Christian Schilling <[email protected]> Date: Tue Jun 4 14:11:15 2019 +0200 Merge pull request #1420 from JuliaReach/schillic/README Update README commit cfae8fd Author: schillic <[email protected]> Date: Tue Jun 4 10:42:22 2019 +0200 update README commit 5b97aec Author: Unknown <[email protected]> Date: Tue Jun 4 18:57:12 2019 +1000 small fixes commit cf01ae6 Author: Unknown <[email protected]> Date: Tue Jun 4 18:50:19 2019 +1000 updated according to comments commit 7e2891f Author: Unknown <[email protected]> Date: Tue Jun 4 17:52:32 2019 +1000 added getting block_structure for CPA and intersection by union of blocks commit a79b038 Author: Unknown <[email protected]> Date: Tue Jun 4 16:33:53 2019 +1000 added block_indices and variable_indices commit b98b789 Author: Unknown <[email protected]> Date: Tue Jun 4 16:31:30 2019 +1000 Added using @view commit ecabee5 Author: Unknown <[email protected]> Date: Tue Jun 4 14:45:14 2019 +1000 updated overaproximation of decomposed linear map according to Christian comments commit ef60e2e Author: Unknown <[email protected]> Date: Sun Jun 2 01:46:13 2019 +1000 Added overapproximation of Lazy linear map of cartesian product array commit af32212 Author: schillic <[email protected]> Date: Fri May 31 17:27:23 2019 +0200 check for emptiness in concrete intersection using Polyhedra commit fd2f305 Author: schillic <[email protected]> Date: Tue May 28 20:17:35 2019 +0200 add isapprox between 'LazySet's
…d Polyhedron Squashed commit of the following: commit 89913f2 Merge: 39d80d6 a96a698 Author: Unknown <[email protected]> Date: Mon Jun 17 01:09:40 2019 +1000 Merge remote-tracking branch 'origin/kostemkin/1041_new' into kostemkin/1041_new commit 39d80d6 Author: Kostiantyn Potomkin <[email protected]> Date: Mon Jun 17 00:46:43 2019 +1000 Added decomposed overapproximate for lazy intersection between CPA and Polyhedron Squashed commit of the following: commit ac50169 Author: Unknown <[email protected]> Date: Sat Jun 15 17:40:24 2019 +1000 added one more test for old overapproximate of lazy intersection commit 509b7f8 Author: Unknown <[email protected]> Date: Sat Jun 15 04:08:49 2019 +1000 added using project commit 795f593 Author: Unknown <[email protected]> Date: Sat Jun 15 03:46:50 2019 +1000 fixed tests commit b722c3c Author: Unknown <[email protected]> Date: Fri Jun 14 19:01:32 2019 +1000 small refactoring in unit_overapproximate commit 89fe48f Merge: 8f6f735 a5545ae Author: Unknown <[email protected]> Date: Fri Jun 14 16:29:31 2019 +1000 Merge remote-tracking branch 'origin/master' into kostemkin/1041_new commit 8f6f735 Author: Unknown <[email protected]> Date: Fri Jun 14 16:28:19 2019 +1000 fixed tests commit 8448622 Author: Unknown <[email protected]> Date: Fri Jun 14 14:38:23 2019 +1000 try to push the test commit a5545ae Author: Marcelo Forets <[email protected]> Date: Thu Jun 13 15:15:09 2019 -0300 Update Project.toml (#1437) commit 9dd9cc9 Author: Marcelo Forets <[email protected]> Date: Thu Jun 13 13:41:53 2019 -0300 Pr/1408 (#1433) * Add TaylorModels optional requirement * Linear case * Nonlinear case commit 413743e Author: Unknown <[email protected]> Date: Fri Jun 14 01:39:07 2019 +1000 fixed tests commit 47f9226 Author: Unknown <[email protected]> Date: Thu Jun 13 16:54:11 2019 +1000 added new tests for decomposed overapproximate and minor refactoring commit a7e8305 Author: Sebastián Guadalupe <[email protected]> Date: Wed Jun 12 18:29:49 2019 -0300 remove redundant vertices of LinearMap (#1428) commit c0fb6d6 Author: Unknown <[email protected]> Date: Thu Jun 13 02:58:12 2019 +1000 some code clean ups according to Christian`s comments commit 6d58c75 Merge: 02916e5 c52a2c4 Author: Christian Schilling <[email protected]> Date: Wed Jun 12 09:56:12 2019 +0200 Merge pull request #1432 from JuliaReach/schillic/times Export 'times' symbol commit c52a2c4 Author: schillic <[email protected]> Date: Wed Jun 12 08:42:55 2019 +0200 export 'times' symbol commit d70ddef Merge: 6427a29 0aa9825 Author: Unknown <[email protected]> Date: Wed Jun 12 14:18:06 2019 +1000 Merge remote-tracking branch 'origin/master' into kostemkin/1041_new commit 6427a29 Author: Unknown <[email protected]> Date: Wed Jun 12 04:03:30 2019 +1000 fixed docs commit 02916e5 Merge: 19b51ea 32a6cfa Author: Christian Schilling <[email protected]> Date: Tue Jun 11 12:17:22 2019 +0200 Merge pull request #1425 from JuliaReach/schillic/merge Simplifications in overapproximate commit b33cab8 Author: Unknown <[email protected]> Date: Tue Jun 11 20:10:58 2019 +1000 further changes in documentation and removing redundant code and comments commit 19b51ea Author: Marcelo Forets <[email protected]> Date: Tue Jun 11 06:34:19 2019 -0300 Update README.md (#1423) * Update README.md * update README and About commit 5f17132 Author: Unknown <[email protected]> Date: Tue Jun 11 15:49:43 2019 +1000 exporting common intersection preprocess part commit b965fb3 Author: Unknown <[email protected]> Date: Tue Jun 11 03:13:14 2019 +1000 export common intersection preprocess part commit 1d55f57 Author: Unknown <[email protected]> Date: Tue Jun 11 02:47:23 2019 +1000 better functions definition in docs and minor refactoring commit 77640db Author: Unknown <[email protected]> Date: Mon Jun 10 19:27:27 2019 +1000 add missing docs commit 133e962 Author: Unknown <[email protected]> Date: Mon Jun 10 18:59:09 2019 +1000 updated doc commit f67024f Author: Unknown <[email protected]> Date: Mon Jun 10 18:54:06 2019 +1000 correct import commit 8b14a4a Author: Unknown <[email protected]> Date: Mon Jun 10 18:51:16 2019 +1000 small refactoring and updated doc commit 0aa9825 Merge: 847ffe8 a56ebc3 Author: Christian Schilling <[email protected]> Date: Fri Jun 7 13:19:45 2019 +0200 Merge pull request #1426 from JuliaReach/schillic/aspectratio Set default aspect ratio in plot recipes to :none commit 06bc249 Author: Unknown <[email protected]> Date: Fri Jun 7 21:00:27 2019 +1000 refactoring to use Vector{Tuple{Int, Int}} for block indices commit a56ebc3 Author: schillic <[email protected]> Date: Fri Jun 7 07:52:54 2019 +0200 set default aspectratio in plot recipes to :none commit 32a6cfa Author: schillic <[email protected]> Date: Thu Jun 6 17:01:58 2019 +0200 simplifications in overapproximate commit 847ffe8 Merge: 2770dd6 af32212 Author: Christian Schilling <[email protected]> Date: Thu Jun 6 13:20:05 2019 +0200 Merge pull request #1414 from JuliaReach/schillic/empty_polytope_intersection Check for emptiness in concrete intersection using Polyhedra commit 2770dd6 Merge: 875ecaf 03823d1 Author: Christian Schilling <[email protected]> Date: Thu Jun 6 13:02:08 2019 +0200 Merge pull request #1419 from JuliaReach/kostemkin/1091 Decomposed linear map of CartesianProductArray commit 875ecaf Merge: 9bc6422 fd2f305 Author: Christian Schilling <[email protected]> Date: Thu Jun 6 12:26:06 2019 +0200 Merge pull request #1409 from JuliaReach/schillic/378 #378 - Add isapprox between sets commit 03823d1 Author: Unknown <[email protected]> Date: Thu Jun 6 18:15:10 2019 +1000 updated tests due to sparse commit 9b8f5be Author: Unknown <[email protected]> Date: Thu Jun 6 18:11:07 2019 +1000 Code clean up commit 16f4a71 Author: Unknown <[email protected]> Date: Thu Jun 6 16:34:15 2019 +1000 fixed tests and function signature commit 2c48134 Author: Unknown <[email protected]> Date: Thu Jun 6 16:27:08 2019 +1000 Moved intersection to overapproximation commit e20224a Author: Unknown <[email protected]> Date: Thu Jun 6 15:50:32 2019 +1000 added new tests and refactoring added functionality to keep the original structure and preallocate corresponding set commit 9bc6422 Author: Marcelo Forets <[email protected]> Date: Wed Jun 5 19:16:55 2019 -0300 Update README.md commit 617de10 Author: Sebastián Guadalupe <[email protected]> Date: Wed Jun 5 19:15:32 2019 -0300 Add three point case for concrete convex hull (#1411) commit 4221528 Merge: e517950 f1aa1ae Author: Christian Schilling <[email protected]> Date: Wed Jun 5 19:05:48 2019 +0200 Merge pull request #1415 from JuliaReach/schillic/571 #571 - Restrict iterative refinement to AbstractFloat commit f1aa1ae Author: schillic <[email protected]> Date: Fri May 31 22:13:59 2019 +0200 restrict type for iterative refinement commit 14a5980 Author: Unknown <[email protected]> Date: Wed Jun 5 20:31:08 2019 +1000 fixed is_intersection_empty to use correct projection commit 5f033d7 Author: Unknown <[email protected]> Date: Wed Jun 5 20:12:34 2019 +1000 removed redundant function commit 6b62873 Author: Unknown <[email protected]> Date: Wed Jun 5 20:08:21 2019 +1000 added correct projection commit 6160bee Author: Unknown <[email protected]> Date: Wed Jun 5 20:06:44 2019 +1000 Removed workarounds for LinearMap projection commit 9f0a8ce Author: Unknown <[email protected]> Date: Wed Jun 5 18:40:25 2019 +1000 Added tests commit a03e868 Author: Unknown <[email protected]> Date: Wed Jun 5 18:18:35 2019 +1000 Added missing is_intersection_empty functions commit 13e7b9c Author: kostakoida <[email protected]> Date: Wed Jun 5 18:00:12 2019 +1000 Update src/Approximations/overapproximate.jl Co-Authored-By: Christian Schilling <[email protected]> commit 80eed63 Author: Unknown <[email protected]> Date: Wed Jun 5 17:55:26 2019 +1000 small refactoring according to Christian's recommendations commit a66586a Author: Unknown <[email protected]> Date: Wed Jun 5 15:47:37 2019 +1000 intersection works commit ece7d74 Author: Unknown <[email protected]> Date: Wed Jun 5 05:23:36 2019 +1000 fixed tests and type instability commit 16521c3 Author: Unknown <[email protected]> Date: Wed Jun 5 05:06:09 2019 +1000 small fixes and added intersection between Cartesian products commit 54d73fd Author: Unknown <[email protected]> Date: Wed Jun 5 04:11:41 2019 +1000 updated linear map to use correct rows and updated tests commit 8742462 Author: Unknown <[email protected]> Date: Wed Jun 5 01:23:36 2019 +1000 added tests commit c7fc98d Author: Unknown <[email protected]> Date: Wed Jun 5 01:10:10 2019 +1000 cleaned up the code commit 80ab0cb Author: Unknown <[email protected]> Date: Tue Jun 4 23:43:19 2019 +1000 Correct minkowski sum addition commit e517950 Merge: 873bbf1 cfae8fd Author: Christian Schilling <[email protected]> Date: Tue Jun 4 14:11:15 2019 +0200 Merge pull request #1420 from JuliaReach/schillic/README Update README commit cfae8fd Author: schillic <[email protected]> Date: Tue Jun 4 10:42:22 2019 +0200 update README commit 5b97aec Author: Unknown <[email protected]> Date: Tue Jun 4 18:57:12 2019 +1000 small fixes commit cf01ae6 Author: Unknown <[email protected]> Date: Tue Jun 4 18:50:19 2019 +1000 updated according to comments commit 7e2891f Author: Unknown <[email protected]> Date: Tue Jun 4 17:52:32 2019 +1000 added getting block_structure for CPA and intersection by union of blocks commit a79b038 Author: Unknown <[email protected]> Date: Tue Jun 4 16:33:53 2019 +1000 added block_indices and variable_indices commit b98b789 Author: Unknown <[email protected]> Date: Tue Jun 4 16:31:30 2019 +1000 Added using @view commit ecabee5 Author: Unknown <[email protected]> Date: Tue Jun 4 14:45:14 2019 +1000 updated overaproximation of decomposed linear map according to Christian comments commit ef60e2e Author: Unknown <[email protected]> Date: Sun Jun 2 01:46:13 2019 +1000 Added overapproximation of Lazy linear map of cartesian product array commit af32212 Author: schillic <[email protected]> Date: Fri May 31 17:27:23 2019 +0200 check for emptiness in concrete intersection using Polyhedra commit fd2f305 Author: schillic <[email protected]> Date: Tue May 28 20:17:35 2019 +0200 add isapprox between 'LazySet's commit a96a698 Author: Kostiantyn Potomkin <[email protected]> Date: Mon Jun 17 00:46:43 2019 +1000 Added decomposed overapproximate for lazy intersection between CPA and Polyhedron Squashed commit of the following: commit ac50169 Author: Unknown <[email protected]> Date: Sat Jun 15 17:40:24 2019 +1000 added one more test for old overapproximate of lazy intersection commit 509b7f8 Author: Unknown <[email protected]> Date: Sat Jun 15 04:08:49 2019 +1000 added using project commit 795f593 Author: Unknown <[email protected]> Date: Sat Jun 15 03:46:50 2019 +1000 fixed tests commit b722c3c Author: Unknown <[email protected]> Date: Fri Jun 14 19:01:32 2019 +1000 small refactoring in unit_overapproximate commit 89fe48f Merge: 8f6f735 a5545ae Author: Unknown <[email protected]> Date: Fri Jun 14 16:29:31 2019 +1000 Merge remote-tracking branch 'origin/master' into kostemkin/1041_new commit 8f6f735 Author: Unknown <[email protected]> Date: Fri Jun 14 16:28:19 2019 +1000 fixed tests commit 8448622 Author: Unknown <[email protected]> Date: Fri Jun 14 14:38:23 2019 +1000 try to push the test commit a5545ae Author: Marcelo Forets <[email protected]> Date: Thu Jun 13 15:15:09 2019 -0300 Update Project.toml (#1437) commit 9dd9cc9 Author: Marcelo Forets <[email protected]> Date: Thu Jun 13 13:41:53 2019 -0300 Pr/1408 (#1433) * Add TaylorModels optional requirement * Linear case * Nonlinear case commit 413743e Author: Unknown <[email protected]> Date: Fri Jun 14 01:39:07 2019 +1000 fixed tests commit 47f9226 Author: Unknown <[email protected]> Date: Thu Jun 13 16:54:11 2019 +1000 added new tests for decomposed overapproximate and minor refactoring commit a7e8305 Author: Sebastián Guadalupe <[email protected]> Date: Wed Jun 12 18:29:49 2019 -0300 remove redundant vertices of LinearMap (#1428) commit c0fb6d6 Author: Unknown <[email protected]> Date: Thu Jun 13 02:58:12 2019 +1000 some code clean ups according to Christian`s comments commit 6d58c75 Merge: 02916e5 c52a2c4 Author: Christian Schilling <[email protected]> Date: Wed Jun 12 09:56:12 2019 +0200 Merge pull request #1432 from JuliaReach/schillic/times Export 'times' symbol commit c52a2c4 Author: schillic <[email protected]> Date: Wed Jun 12 08:42:55 2019 +0200 export 'times' symbol commit d70ddef Merge: 6427a29 0aa9825 Author: Unknown <[email protected]> Date: Wed Jun 12 14:18:06 2019 +1000 Merge remote-tracking branch 'origin/master' into kostemkin/1041_new commit 6427a29 Author: Unknown <[email protected]> Date: Wed Jun 12 04:03:30 2019 +1000 fixed docs commit 02916e5 Merge: 19b51ea 32a6cfa Author: Christian Schilling <[email protected]> Date: Tue Jun 11 12:17:22 2019 +0200 Merge pull request #1425 from JuliaReach/schillic/merge Simplifications in overapproximate commit b33cab8 Author: Unknown <[email protected]> Date: Tue Jun 11 20:10:58 2019 +1000 further changes in documentation and removing redundant code and comments commit 19b51ea Author: Marcelo Forets <[email protected]> Date: Tue Jun 11 06:34:19 2019 -0300 Update README.md (#1423) * Update README.md * update README and About commit 5f17132 Author: Unknown <[email protected]> Date: Tue Jun 11 15:49:43 2019 +1000 exporting common intersection preprocess part commit b965fb3 Author: Unknown <[email protected]> Date: Tue Jun 11 03:13:14 2019 +1000 export common intersection preprocess part commit 1d55f57 Author: Unknown <[email protected]> Date: Tue Jun 11 02:47:23 2019 +1000 better functions definition in docs and minor refactoring commit 77640db Author: Unknown <[email protected]> Date: Mon Jun 10 19:27:27 2019 +1000 add missing docs commit 133e962 Author: Unknown <[email protected]> Date: Mon Jun 10 18:59:09 2019 +1000 updated doc commit f67024f Author: Unknown <[email protected]> Date: Mon Jun 10 18:54:06 2019 +1000 correct import commit 8b14a4a Author: Unknown <[email protected]> Date: Mon Jun 10 18:51:16 2019 +1000 small refactoring and updated doc commit 0aa9825 Merge: 847ffe8 a56ebc3 Author: Christian Schilling <[email protected]> Date: Fri Jun 7 13:19:45 2019 +0200 Merge pull request #1426 from JuliaReach/schillic/aspectratio Set default aspect ratio in plot recipes to :none commit 06bc249 Author: Unknown <[email protected]> Date: Fri Jun 7 21:00:27 2019 +1000 refactoring to use Vector{Tuple{Int, Int}} for block indices commit a56ebc3 Author: schillic <[email protected]> Date: Fri Jun 7 07:52:54 2019 +0200 set default aspectratio in plot recipes to :none commit 32a6cfa Author: schillic <[email protected]> Date: Thu Jun 6 17:01:58 2019 +0200 simplifications in overapproximate commit 847ffe8 Merge: 2770dd6 af32212 Author: Christian Schilling <[email protected]> Date: Thu Jun 6 13:20:05 2019 +0200 Merge pull request #1414 from JuliaReach/schillic/empty_polytope_intersection Check for emptiness in concrete intersection using Polyhedra commit 2770dd6 Merge: 875ecaf 03823d1 Author: Christian Schilling <[email protected]> Date: Thu Jun 6 13:02:08 2019 +0200 Merge pull request #1419 from JuliaReach/kostemkin/1091 Decomposed linear map of CartesianProductArray commit 875ecaf Merge: 9bc6422 fd2f305 Author: Christian Schilling <[email protected]> Date: Thu Jun 6 12:26:06 2019 +0200 Merge pull request #1409 from JuliaReach/schillic/378 #378 - Add isapprox between sets commit 03823d1 Author: Unknown <[email protected]> Date: Thu Jun 6 18:15:10 2019 +1000 updated tests due to sparse commit 9b8f5be Author: Unknown <[email protected]> Date: Thu Jun 6 18:11:07 2019 +1000 Code clean up commit 16f4a71 Author: Unknown <[email protected]> Date: Thu Jun 6 16:34:15 2019 +1000 fixed tests and function signature commit 2c48134 Author: Unknown <[email protected]> Date: Thu Jun 6 16:27:08 2019 +1000 Moved intersection to overapproximation commit e20224a Author: Unknown <[email protected]> Date: Thu Jun 6 15:50:32 2019 +1000 added new tests and refactoring added functionality to keep the original structure and preallocate corresponding set commit 9bc6422 Author: Marcelo Forets <[email protected]> Date: Wed Jun 5 19:16:55 2019 -0300 Update README.md commit 617de10 Author: Sebastián Guadalupe <[email protected]> Date: Wed Jun 5 19:15:32 2019 -0300 Add three point case for concrete convex hull (#1411) commit 4221528 Merge: e517950 f1aa1ae Author: Christian Schilling <[email protected]> Date: Wed Jun 5 19:05:48 2019 +0200 Merge pull request #1415 from JuliaReach/schillic/571 #571 - Restrict iterative refinement to AbstractFloat commit f1aa1ae Author: schillic <[email protected]> Date: Fri May 31 22:13:59 2019 +0200 restrict type for iterative refinement commit 14a5980 Author: Unknown <[email protected]> Date: Wed Jun 5 20:31:08 2019 +1000 fixed is_intersection_empty to use correct projection commit 5f033d7 Author: Unknown <[email protected]> Date: Wed Jun 5 20:12:34 2019 +1000 removed redundant function commit 6b62873 Author: Unknown <[email protected]> Date: Wed Jun 5 20:08:21 2019 +1000 added correct projection commit 6160bee Author: Unknown <[email protected]> Date: Wed Jun 5 20:06:44 2019 +1000 Removed workarounds for LinearMap projection commit 9f0a8ce Author: Unknown <[email protected]> Date: Wed Jun 5 18:40:25 2019 +1000 Added tests commit a03e868 Author: Unknown <[email protected]> Date: Wed Jun 5 18:18:35 2019 +1000 Added missing is_intersection_empty functions commit 13e7b9c Author: kostakoida <[email protected]> Date: Wed Jun 5 18:00:12 2019 +1000 Update src/Approximations/overapproximate.jl Co-Authored-By: Christian Schilling <[email protected]> commit 80eed63 Author: Unknown <[email protected]> Date: Wed Jun 5 17:55:26 2019 +1000 small refactoring according to Christian's recommendations commit a66586a Author: Unknown <[email protected]> Date: Wed Jun 5 15:47:37 2019 +1000 intersection works commit ece7d74 Author: Unknown <[email protected]> Date: Wed Jun 5 05:23:36 2019 +1000 fixed tests and type instability commit 16521c3 Author: Unknown <[email protected]> Date: Wed Jun 5 05:06:09 2019 +1000 small fixes and added intersection between Cartesian products commit 54d73fd Author: Unknown <[email protected]> Date: Wed Jun 5 04:11:41 2019 +1000 updated linear map to use correct rows and updated tests commit 8742462 Author: Unknown <[email protected]> Date: Wed Jun 5 01:23:36 2019 +1000 added tests commit c7fc98d Author: Unknown <[email protected]> Date: Wed Jun 5 01:10:10 2019 +1000 cleaned up the code commit 80ab0cb Author: Unknown <[email protected]> Date: Tue Jun 4 23:43:19 2019 +1000 Correct minkowski sum addition commit e517950 Merge: 873bbf1 cfae8fd Author: Christian Schilling <[email protected]> Date: Tue Jun 4 14:11:15 2019 +0200 Merge pull request #1420 from JuliaReach/schillic/README Update README commit cfae8fd Author: schillic <[email protected]> Date: Tue Jun 4 10:42:22 2019 +0200 update README commit 5b97aec Author: Unknown <[email protected]> Date: Tue Jun 4 18:57:12 2019 +1000 small fixes commit cf01ae6 Author: Unknown <[email protected]> Date: Tue Jun 4 18:50:19 2019 +1000 updated according to comments commit 7e2891f Author: Unknown <[email protected]> Date: Tue Jun 4 17:52:32 2019 +1000 added getting block_structure for CPA and intersection by union of blocks commit a79b038 Author: Unknown <[email protected]> Date: Tue Jun 4 16:33:53 2019 +1000 added block_indices and variable_indices commit b98b789 Author: Unknown <[email protected]> Date: Tue Jun 4 16:31:30 2019 +1000 Added using @view commit ecabee5 Author: Unknown <[email protected]> Date: Tue Jun 4 14:45:14 2019 +1000 updated overaproximation of decomposed linear map according to Christian comments commit ef60e2e Author: Unknown <[email protected]> Date: Sun Jun 2 01:46:13 2019 +1000 Added overapproximation of Lazy linear map of cartesian product array commit af32212 Author: schillic <[email protected]> Date: Fri May 31 17:27:23 2019 +0200 check for emptiness in concrete intersection using Polyhedra commit fd2f305 Author: schillic <[email protected]> Date: Tue May 28 20:17:35 2019 +0200 add isapprox between 'LazySet's commit 894fda3 Merge: d9da4d4 0fd6c1e Author: Christian Schilling <[email protected]> Date: Fri Jun 14 22:27:55 2019 +0200 Merge pull request #1442 from JuliaReach/schillic/1364 #1364 - Concrete linear map of a translation commit 0fd6c1e Author: schillic <[email protected]> Date: Fri Jun 14 16:19:22 2019 +0200 concrete linear_map of lazy Translation
Closes #1383.
Closes #1418.