Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default absolute zero tolerance in Floats #1341

Merged
merged 1 commit into from
May 6, 2019

Conversation

mforets
Copy link
Member

@mforets mforets commented May 4, 2019

No description provided.

@schillic
Copy link
Member

schillic commented May 4, 2019

Any reason?

@mforets
Copy link
Member Author

mforets commented May 5, 2019

Good question and the short answer is that experiments suggest that sqrt(eps(Float64)) is too small for the discrete post. A "typical" calculation with the bouncing ball and octagon directions needs ~5e-8 to take the intersection properly, and since sqrt(eps(Float64)) = 1.4901161193847656e-8 then it's not that far.

I plan to provide more details soon -- probably after we add the global way to handle the abstol, making it easier for tests in Reachability.

@schillic
Copy link
Member

schillic commented May 5, 2019

Hm, okay.

@mforets mforets merged commit 15cddba into master May 6, 2019
@mforets mforets deleted the mforets/change_default_absztol branch May 6, 2019 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants