Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getter function for the generators of a Zonotope #1313

Merged
merged 1 commit into from
May 2, 2019

Conversation

aa25desh
Copy link
Contributor

@aa25desh aa25desh commented Apr 29, 2019

Closes #1309.

Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the following:

  • Add export generators at the top of Zonotope.jl. This makes the function available without explicitly importing it.
  • Add the function to the documentation in docs/src/lib/representation.jl under ## Zonotope. Otherwise our build will fail.

Also, we try to have unit tests for everything in this package, so please add one to test/unit_Zonotope.jl.

src/Zonotope.jl Show resolved Hide resolved
@mforets mforets changed the title getter function for the generator of a Zonotope Getter function for the generators of a Zonotope Apr 30, 2019
@schillic
Copy link
Member

The unit test here would be very silly, but still it's better to have it:

@test generators(Z) == Z.generators

for some zonotope Z.

@schillic
Copy link
Member

Thanks. We want to fix some internals first, so let's wait with merging here. Maybe I can fix things tomorrow.

Update Zonotope.jl

Update Zonotope.jl

Update representations.md

Update unit_Zonotope.jl
@schillic schillic merged commit 5440338 into JuliaReach:master May 2, 2019
@schillic
Copy link
Member

schillic commented May 2, 2019

@aadesha: If you want, you can add your name here (in a new pull request).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add getter function for the generator of a Zonotope
3 participants