Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Expokit an optional requirement #1290

Merged
merged 6 commits into from
Apr 27, 2019
Merged

Make Expokit an optional requirement #1290

merged 6 commits into from
Apr 27, 2019

Conversation

schillic
Copy link
Member

No description provided.

@schillic schillic requested a review from mforets April 17, 2019 20:29
@codecov-io
Copy link

codecov-io commented Apr 17, 2019

Codecov Report

Merging #1290 into master will decrease coverage by 4.12%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1290      +/-   ##
==========================================
- Coverage   90.41%   86.29%   -4.13%     
==========================================
  Files          63       62       -1     
  Lines        3213     2728     -485     
==========================================
- Hits         2905     2354     -551     
- Misses        308      374      +66
Impacted Files Coverage Δ
src/ExponentialMap.jl 96.66% <100%> (-3.34%) ⬇️
src/init.jl 85.71% <80%> (-14.29%) ⬇️
src/compat.jl 50% <0%> (-50%) ⬇️
src/Approximations/template_directions.jl 51.79% <0%> (-42.36%) ⬇️
src/Approximations/Approximations.jl 57.14% <0%> (-30.36%) ⬇️
src/Hyperrectangle.jl 54.16% <0%> (-29.84%) ⬇️
src/helper_functions.jl 75.59% <0%> (-17.08%) ⬇️
src/BallInf.jl 84.61% <0%> (-15.39%) ⬇️
src/Complement.jl 85.71% <0%> (-14.29%) ⬇️
src/ZeroSet.jl 86.66% <0%> (-13.34%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fe52d4...7c950f5. Read the comment docs.

Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the first example of the Introduction now we need to add using Expokit.

docs/src/man/getting_started.md Show resolved Hide resolved
@schillic schillic requested a review from mforets April 27, 2019 07:15
@schillic schillic merged commit 8230c8c into master Apr 27, 2019
@schillic schillic deleted the schillic/expokit branch April 27, 2019 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants