Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spherical directions #1255

Merged
merged 10 commits into from
Mar 28, 2019
Merged

Add spherical directions #1255

merged 10 commits into from
Mar 28, 2019

Conversation

mforets
Copy link
Member

@mforets mforets commented Mar 27, 2019

No description provided.

@mforets mforets requested a review from schillic March 27, 2019 18:53
@mforets
Copy link
Member Author

mforets commented Mar 27, 2019

Test pass locally on v1.1, i haven't tested in v0.6 though..

Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am quite surprised that, in the example, 7 out of 9 directions are redundant. Are you sure this is correct?

src/Approximations/template_directions.jl Show resolved Hide resolved
src/Approximations/template_directions.jl Outdated Show resolved Hide resolved
src/Approximations/template_directions.jl Outdated Show resolved Hide resolved
src/Approximations/template_directions.jl Outdated Show resolved Hide resolved
src/Approximations/template_directions.jl Outdated Show resolved Hide resolved
src/Approximations/template_directions.jl Outdated Show resolved Hide resolved
src/Approximations/template_directions.jl Outdated Show resolved Hide resolved
src/Approximations/template_directions.jl Outdated Show resolved Hide resolved
src/Approximations/template_directions.jl Outdated Show resolved Hide resolved
test/unit_template_directions.jl Outdated Show resolved Hide resolved
src/Approximations/template_directions.jl Outdated Show resolved Hide resolved
@mforets mforets mentioned this pull request Mar 28, 2019
@mforets mforets merged commit cbc49f0 into master Mar 28, 2019
@schillic schillic deleted the mforets/spherical_coordinates branch March 28, 2019 20:07
@schillic
Copy link
Member

This changeset was breaking in Julia v0.6!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants