Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1245 - Zonotope conversion from flat hyperrectangle contains zero generators #1246

Merged
merged 3 commits into from
Mar 23, 2019
Merged

#1245 - Zonotope conversion from flat hyperrectangle contains zero generators #1246

merged 3 commits into from
Mar 23, 2019

Conversation

schillic
Copy link
Member

Closes #1245.

@schillic schillic requested a review from mforets March 23, 2019 09:54
@mforets
Copy link
Member

mforets commented Mar 23, 2019

Let's remove the zero columns in creation of the zonotope? With an option remove_zero_gens (default, true).

mforets
mforets reviewed Mar 23, 2019
View reviewed changes
src/helper_functions.jl Outdated Show resolved Hide resolved
@schillic schillic requested a review from mforets March 23, 2019 12:01
mforets
mforets approved these changes Mar 23, 2019
View reviewed changes
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@schillic schillic merged commit e4dbcf2 into master Mar 23, 2019
@schillic schillic deleted the schillic/1245 branch March 23, 2019 12:23
@schillic schillic mentioned this pull request Mar 23, 2019
Closed
@mforets mforets mentioned this pull request Mar 23, 2019
Merged
@mforets mforets mentioned this pull request Mar 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schillic @mforets