Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1219 - Subset check between CartesianProductArrays #1225

Merged
merged 3 commits into from
Mar 12, 2019
Merged

#1219 - Subset check between CartesianProductArrays #1225

merged 3 commits into from
Mar 12, 2019

Conversation

schillic
Copy link
Member

Closes #1219.

@schillic schillic requested a review from mforets March 11, 2019 18:58
mforets
mforets reviewed Mar 12, 2019
View reviewed changes
src/is_subset.jl Outdated Show resolved Hide resolved
@mforets mforets mentioned this pull request Mar 12, 2019
Closed
@mforets
Copy link
Member

mforets commented Mar 12, 2019

These ideas can also be brought to the binary CartesianProduct type; I've opened #1227.

mforets
mforets approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@schillic schillic merged commit 7938608 into master Mar 12, 2019
@schillic schillic deleted the schillic/1219 branch March 12, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schillic @mforets