#1159 - Add subtypes function with concrete argument #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforets
changed the title
schillic
approved these changes
Mar 2, 2019
schillic
reviewed
Mar 2, 2019
src/LazySet.jl
Outdated
| @@ -33,6 +33,8 @@ Every concrete `LazySet` must define the following functions: | |||
| `Real` | |||
| - `dim(S::LazySet)::Int` -- the ambient dimension of `S` | |||
|
|
|||
| The subytpes of `LazySet`, including abstract interfaces: | |||
There was a problem hiding this comment.
I am not sure if this is interesting, because it does not contain all interfaces. But okay...
There was a problem hiding this comment.
Ok, i see. Would be nice to have an option to list all abstract interfaces as only...
schillic
reviewed
Mar 2, 2019
schillic
approved these changes
Mar 2, 2019
mforets
commented
Mar 2, 2019
mforets
commented
Mar 2, 2019
mforets
commented
Mar 2, 2019
mforets
commented
Mar 2, 2019
schillic
reviewed
Mar 2, 2019
schillic
reviewed
Mar 2, 2019
schillic
approved these changes
Mar 4, 2019
|
Thanks for the review. There is still this travis CI timeout problem that affect v1.0 tests. Not related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1159.