Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1177 - Revise decompose interface #1179

Merged
merged 8 commits into from
Mar 2, 2019
Merged

#1177 - Revise decompose interface #1179

merged 8 commits into from
Mar 2, 2019

Conversation

schillic
Copy link
Member

@schillic schillic commented Feb 28, 2019 •
edited
Loading

Closes #1177.

  • new interface
  • add convenience methods
  • adapt tests
  • add parts of the old docs with the (adapted) examples again
  • add option block_size

@schillic schillic force-pushed the schillic/1177 branch 3 times, most recently from 625f24a to b4fba41 Compare March 1, 2019 19:13
@schillic schillic changed the title WIP #1177 - Revise decompose interface #1177 - Revise decompose interface Mar 1, 2019
@schillic schillic requested a review from mforets March 1, 2019 21:48
@mforets mforets mentioned this pull request Mar 2, 2019
Merged
@mforets
Copy link
Member

mforets commented Mar 2, 2019

Looks good!

@schillic schillic merged commit 76d7e38 into master Mar 2, 2019
@schillic schillic deleted the schillic/1177 branch March 2, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schillic @mforets