#1052 - Add constraints list of a lazy linear map #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforets
reviewed
Jan 23, 2019
| @@ -328,7 +329,7 @@ A list of vertices. | |||
|
|
|||
| ### Algorithm | |||
|
|
|||
| We assume that the underlying set `X` is polytopic. | |||
| We assume that the underlying set `X` is polyhedral. | |||
There was a problem hiding this comment.
what about using an interface for the dispatch? LinearMap{N, S} where {S<:AbstractPolytope}
There was a problem hiding this comment.
- This PR is about
constraints_list. - This is the old dispute about lazy operations. There are other sets that offer
constraints_list(such asHPolyhedron).
In this PR (constraints_list) I used the interface as you did inIntersection, but to be honest now things are inconsistent.
schillic
force-pushed
the
schillic/1052
branch
from
d349260 to
fd0e598
Compare
mforets
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1052.