Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More efficient support vector/function for UnionSetArray #993

Closed
schillic opened this issue Jan 12, 2019 · 0 comments · Fixed by #3308
Closed

More efficient support vector/function for UnionSetArray #993

schillic opened this issue Jan 12, 2019 · 0 comments · Fixed by #3308
Assignees
Labels
performance 🐎 More efficient code

Comments

@schillic
Copy link
Member

Our implementation of the support vector and support function for UnionSetArray in #922 obtains the values for all sets and then chooses the maximizing argument. Instead, one can compute these results iteratively and compare to the currently best one found. So one only needs to store two results at a time.

@schillic schillic added the performance 🐎 More efficient code label Jan 12, 2019
@schillic schillic mentioned this issue Jan 12, 2019
@schillic schillic self-assigned this Apr 19, 2023
schillic added a commit that referenced this issue May 5, 2023
#993 - More efficient support vector for UnionSet and UnionSetArray
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance 🐎 More efficient code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant