-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing doctests should fail the build #71
Comments
In my recent commits I did not include unit tests but only doctests. Assuming this issue is resolved, they should be equivalent from the automatic builds view (fails iff one of the tests breaks).
I do not have a strong opinion here. We could also have both, but then one of the tests is obviously redundant. |
@mforets asked about this in the Documenter repo. |
In #677 i set the I'm not proposing this measure to be definitive, but i'm reopening this issue to keep it in mind. Maybe we should add the $ julia --color=yes docs/make.jl --strict=true |
There is now a new documentation for using build stages. After the jump to v1.0, we should try this again. |
Now that we have #1351, I would say we can close this. |
@mforets: Currently there is a failing doctest in master:
However, Travis does not complain.
See here how to potentially implement this.
The text was updated successfully, but these errors were encountered: