Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Plots from REQUIRE #647

Closed
schillic opened this issue Sep 22, 2018 · 3 comments
Closed

Remove Plots from REQUIRE #647

schillic opened this issue Sep 22, 2018 · 3 comments
Assignees
Labels
usability 🖱️ Simplifies the usage or interface

Comments

@schillic
Copy link
Member

The library should not have the requirement Plots.jl, which is only used for plotting. We have RecipesBase.jl for defining the plot recipes.

@schillic schillic added the usability 🖱️ Simplifies the usage or interface label Sep 22, 2018
@schillic schillic self-assigned this Sep 22, 2018
@mforets
Copy link
Member

mforets commented Sep 22, 2018

does removing this requirement conflict with having plot commands in the unit tests?

@schillic
Copy link
Member Author

We have to add it manually before running the tests/building the docs of course. But to use the package, it should not be required.

schillic added a commit that referenced this issue Sep 22, 2018
@mforets
Copy link
Member

mforets commented Sep 22, 2018

But to use the package, it should not be required.

I am neutral on this one, because the user would need Plots in most use cases. But it's true that visualization is is as optional as Polyhedra for concrete polyhedra so i think it is consistent to make the user install it separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability 🖱️ Simplifies the usage or interface
Projects
None yet
Development

No branches or pull requests

2 participants