Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polytopes' intersect should be intersection #595

Closed
mforets opened this issue Aug 29, 2018 · 0 comments
Closed

Polytopes' intersect should be intersection #595

mforets opened this issue Aug 29, 2018 · 0 comments
Assignees
Labels
fix 🤕 Fix to a problem that is not too serious

Comments

@mforets
Copy link
Member

mforets commented Aug 29, 2018

Concrete intersection has been called "intersection", while lazy intersection is ∩ , spelled out as "intersect", for the case of rectangles:

julia> B1 = BallInf(ones(2), 1.);

julia> B2 = BallInf(ones(2), 1.);

julia> intersection(B1, B2)

LazySets.Hyperrectangle{Float64}([1.0, 1.0], [1.0, 1.0])

julia> intersect(B1, B2)
LazySets.Intersection{Float64,LazySets.BallInf{Float64},LazySets.BallInf{Float64}}(LazySets.BallInf{Float64}([1.0, 1.0], 1.0), LazySets.BallInf{Float64}([1.0, 1.0], 1.0))

This is to propose adjusting the function's name in

    intersect(P1::HPolytope{N}, P2::HPolytope{N};
              [backend]=CDDLib.CDDLibrary(),
              [prunefunc]=removehredundancy!)::HPolytope{N} where {N<:Real}

and the corresponging one for VPolytope.

@schillic schillic added the fix 🤕 Fix to a problem that is not too serious label Aug 30, 2018
@schillic schillic changed the title HPolytopes intersect should be intersection Polytopes' intersect should be intersection Aug 30, 2018
mforets added a commit that referenced this issue Aug 30, 2018
#595 - Polytopes intersect should be intersection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🤕 Fix to a problem that is not too serious
Projects
None yet
Development

No branches or pull requests

2 participants