Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize exponential backend in symmetric_interval_hull methods #3117

Closed
schillic opened this issue Oct 9, 2022 · 0 comments · Fixed by #3253
Closed

Generalize exponential backend in symmetric_interval_hull methods #3117

schillic opened this issue Oct 9, 2022 · 0 comments · Fixed by #3253
Assignees
Labels
compatibility 🤝 Integration with other packages extension ⬆️ Extension of an existing feature

Comments

@schillic
Copy link
Member

schillic commented Oct 9, 2022

The Approximations module only supports Expokit as exponential backend:

function symmetric_interval_hull(E::ExponentialMap{N, <:AbstractSingleton}) where {N}
require(@__MODULE__, :Expokit; fun_name="symmetric_interval_hull")
v = expmv(one(N), E.spmexp.M, element(E.X))
c = zeros(N, dim(E))
r = abs.(v)
return Hyperrectangle(c, r)
end
function symmetric_interval_hull(E::ExponentialMap{N, <:AbstractHyperrectangle}) where {N}
require(@__MODULE__, :Expokit; fun_name="symmetric_interval_hull")

Instead it should use the code from the main LazySets module:

function get_exponential_backend()

@schillic schillic added extension ⬆️ Extension of an existing feature compatibility 🤝 Integration with other packages labels Oct 9, 2022
@schillic schillic self-assigned this Apr 2, 2023
schillic added a commit that referenced this issue Apr 5, 2023
#3117 - Generalize exponential backend in symmetric_interval_hull methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility 🤝 Integration with other packages extension ⬆️ Extension of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant