Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize dimension of overapproximate(S, ::Hyperrectangle) #287

Closed
schillic opened this issue Mar 10, 2018 · 3 comments
Closed

Generalize dimension of overapproximate(S, ::Hyperrectangle) #287

schillic opened this issue Mar 10, 2018 · 3 comments
Assignees
@schillic
Labels
usability 🖱️ Simplifies the usage or interface
Milestone
TAC

Comments

@schillic
Copy link
Member

Currently it only works for dimension two. However, we should have at least one type of higher dimension, and it would be rather simple in this case.
@schillic schillic added the usability 🖱️ Simplifies the usage or interface label Mar 10, 2018
@schillic schillic added this to the TAC milestone Mar 10, 2018
@mforets
Copy link
Member

mforets commented Mar 10, 2018

If i'm not mistaken it amounts to calling box_approximation from Approximations.

@schillic
Copy link
Member Author

schillic commented Mar 10, 2018 •
edited
Loading

Do we need the 2D version?
I think we can just do overapproximate(S::LazySet, ::Type{<:Hyperrectangle}) = box_approximation(S).

@mforets
Copy link
Member

mforets commented Mar 10, 2018 •
edited
Loading

I think we can just do overapproximate(S::LazySet, ::Type{<:Hyperrectangle}) = box_approximation(S).

Yes.

@schillic schillic mentioned this issue Mar 10, 2018
Merged
schillic added a commit that referenced this issue Mar 10, 2018
@schillic
Merge pull request #289 from JuliaReach/schillic/287
e73f93d 
#287 - generalize overapproximate(S, ::Hyperrectangle) to nD
@schillic schillic self-assigned this Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schillic schillic

Labels
usability 🖱️ Simplifies the usage or interface
Projects
None yet
Milestone
TAC
Development

No branches or pull requests
2 participants
@schillic @mforets