Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertices_list of an empty HParallelotope is non-empty #2786

Closed
schillic opened this issue Jul 15, 2021 · 0 comments · Fixed by #3219
Closed

vertices_list of an empty HParallelotope is non-empty #2786

schillic opened this issue Jul 15, 2021 · 0 comments · Fixed by #3219
Assignees
Labels
fix 🤕 Fix to a problem that is not too serious

Comments

@schillic
Copy link
Member

schillic commented Jul 15, 2021

julia> H = [1.0 1.0; 0.0 1.0];
julia> o = [2.5, 2.0, -4.0, -1.0];
julia> Pl = HParallelotope(H, o);  # this set is empty

julia> vertices_list(Pl)
4-element Vector{Vector{Float64}}:
 [2.0, 2.0]
 [0.5, 2.0]
 [1.5, 1.0]
 [3.0, 1.0]

The question is whether we want to fix this because in a sense the set is illegal: we do not allow empty parallelotopes conceptually. We want to fix vertices_list.

@schillic schillic added discussion 🗣️ Requires human input fix 🤕 Fix to a problem that is not too serious labels Jul 15, 2021
@schillic schillic removed the discussion 🗣️ Requires human input label Nov 16, 2021
@schillic schillic self-assigned this Dec 16, 2022
schillic added a commit that referenced this issue Feb 27, 2023
#2786 - Add consistency check to HParallelotope constructor and use cheap isempty method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🤕 Fix to a problem that is not too serious
Projects
None yet
1 participant