Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify code in 2D minkowski_sum (after Julia error gets fixed) #2778

Closed
schillic opened this issue Jul 13, 2021 · 0 comments · Fixed by #3327
Closed

Simplify code in 2D minkowski_sum (after Julia error gets fixed) #2778

schillic opened this issue Jul 13, 2021 · 0 comments · Fixed by #3327
Assignees
@schillic
Labels
external 📤 Related to external packages refactoring 🔧 Internal code changes, typically no impact on API

Comments

@schillic
Copy link
Member

In #2753 we used a workaround to avoid a Julia error. When that error gets fixed, we should remove the code duplication again. The relevant lines are 55-64 (remove) resp. 65 (uncomment) here.
@schillic schillic added external 📤 Related to external packages refactoring 🔧 Internal code changes, typically no impact on API labels Jul 13, 2021
@schillic schillic self-assigned this May 17, 2023
@schillic schillic mentioned this issue May 17, 2023
Merged
schillic added a commit that referenced this issue May 18, 2023
@schillic
Merge pull request #3327 from JuliaReach/schillic/2778
61e1d3b 
#2778 - Simplify code in 2D minkowski_sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schillic schillic

Labels
external 📤 Related to external packages refactoring 🔧 Internal code changes, typically no impact on API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2778 - Simplify code in 2D minkowski_sum JuliaReach/LazySets.jl
1 participant
@schillic