Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not depend on Plots.jl for testing #2139

Closed
giordano opened this issue Apr 24, 2020 · 5 comments · Fixed by #2595
Closed

Do not depend on Plots.jl for testing #2139

giordano opened this issue Apr 24, 2020 · 5 comments · Fixed by #2595
Assignees

Comments

@giordano
Copy link

Plots.jl is a huge dependency. As far as I can see, in test/unit_plot.jl you are not even testing anything. I recommend you to look at what I do in Measurements.jl to test plotting functionalities simply using RecipesBase.jl, so that you can remove Plots.jl and actually test something meaningful.

@mforets
Copy link
Member

mforets commented Apr 24, 2020

Thanks for the tip @giordano, we'll consider it. In this library a full run of CI usually takes like ~40minutes on Travis 😫 So if this can reduce such runtimes while having some tests for the plotting stuff it would already be a win.

@schillic
Copy link
Member

We also need Plots for the documentation. I am not sure that this would resolve #2098 (I just commented there).

@giordano
Copy link
Author

In this library a full run of CI usually takes like ~40minutes on Travis tired_face So if this can reduce such runtimes while having some tests for the plotting stuff it would already be a win.

Well, not sure if it'll reduce sensibly from 40 minutes, but in a smaller project I was able to shave off 3 minutes per job by moving from Plots to RecipesBase

We also need Plots for the documentation.

That's one job out of the 5 total, no?

@giordano
Copy link
Author

Also, consider caching artifacts in CI: https://discourse.julialang.org/t/recommendation-cache-julia-artifacts-in-ci-services/35484. That would help in jobs for Julia v1.3+

@mforets
Copy link
Member

mforets commented Feb 26, 2021

thanks @giordano for all the tips 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants