-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not depend on Plots.jl for testing #2139
Comments
Thanks for the tip @giordano, we'll consider it. In this library a full run of CI usually takes like ~40minutes on Travis 😫 So if this can reduce such runtimes while having some tests for the plotting stuff it would already be a win. |
We also need |
Well, not sure if it'll reduce sensibly from 40 minutes, but in a smaller project I was able to shave off 3 minutes per job by moving from Plots to RecipesBase
That's one job out of the 5 total, no? |
Also, consider caching artifacts in CI: https://discourse.julialang.org/t/recommendation-cache-julia-artifacts-in-ci-services/35484. That would help in jobs for Julia v1.3+ |
#2139 - Do not depend on Plots.jl for testing
thanks @giordano for all the tips 💯 |
Plots.jl
is a huge dependency. As far as I can see, intest/unit_plot.jl
you are not even testing anything. I recommend you to look at what I do inMeasurements.jl
to test plotting functionalities simply usingRecipesBase.jl
, so that you can removePlots.jl
and actually test something meaningful.The text was updated successfully, but these errors were encountered: