Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Tolerance for getfield in comparison of sets of the same type #1823

Closed
mforets opened this issue Dec 10, 2019 · 0 comments · Fixed by #1824
Closed

Use Tolerance for getfield in comparison of sets of the same type #1823

mforets opened this issue Dec 10, 2019 · 0 comments · Fixed by #1824
Labels
robustness 💪 Tests and checks

Comments

@mforets
Copy link
Member

mforets commented Dec 10, 2019

LazySets.jl/src/Interfaces/LazySet.jl

Line 437 in 932e804

if !(getfield(X, f) ≈ getfield(Y, f))

@mforets mforets added the robustness 💪 Tests and checks label Dec 10, 2019
@mforets mforets mentioned this issue Dec 10, 2019
Merged
mforets added a commit that referenced this issue Dec 12, 2019
@mforets @schillic
#1823 - Use Tolerance for getfield in comparison of sets of the same …
8f371b3 
…type (#1824)

* Update LazySet.jl

* define promotion rules in comparisons

* Add default tolerance for Int and for Rational

* Update src/Utils/comparisons.jl

Co-Authored-By: Christian Schilling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
robustness 💪 Tests and checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1823 - Use Tolerance for getfield in comparison of sets of the same type JuliaReach/LazySets.jl
1 participant
@mforets