Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic concrete minkowski sum #1599

Closed
mforets opened this issue Aug 13, 2019 · 1 comment · Fixed by #2753
Closed

Generic concrete minkowski sum #1599

mforets opened this issue Aug 13, 2019 · 1 comment · Fixed by #2753
Assignees
Labels
performance 🐎 More efficient code

Comments

@mforets
Copy link
Member

mforets commented Aug 13, 2019

By generics i mean function that dispatch on LazySets. We can check if the argument is 2D then use the concrete minkowski sum in v-representation. It is more efficient than using the higher-dimensional approach (see #1597).

@mforets mforets added the performance 🐎 More efficient code label Aug 13, 2019
@mforets
Copy link
Member Author

mforets commented Aug 13, 2019

There are different choices, this is one possibility:

  • if the set is 2D
    • if the vertices_list is available => use _minkowski_sum_vrep
    • else if the constraints_list is available => use _minkowski_sum_hrep
    • else error
  • else if the set is > 2D
    • if the constraints_list is available => use _minkowski_sum_hrep
    • else if the vertices_list is available => use _minkowski_sum_vrep
    • else error

@mforets mforets changed the title Generic concrete minkowski sum in 2D Generic concrete minkowski sum Sep 21, 2019
@schillic schillic self-assigned this Jun 27, 2021
schillic added a commit that referenced this issue Jul 13, 2021
* better concrete Minkowski sum of 2D polytopes

* updates

* remove convex hull

* refactor convex_hull in 2D

* bring back convex hull

* fix test

Co-authored-by: mforets <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance 🐎 More efficient code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants