Merge pull request #3333 from JuliaReach/schillic/3226

Do not use GLPK's presolver by default
JuliaReach · Jun 5, 2023 · 494db08 · 494db08
2 parents 6ab9dca + 8ce5fd7
commit 494db08
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/ConcreteOperations/intersection.jl b/src/ConcreteOperations/intersection.jl
@@ -746,13 +746,13 @@ function intersection(P1::Union{VPolygon,VPolytope},
     Q2 = polyhedron(P2; backend=backend)
     Pint = Polyhedra.intersect(Q1, Q2)
 
+    N = promote_type(eltype(P1), eltype(P2))
     if isnothing(prunefunc)
-        prunefunc = (X -> removevredundancy!(X; ztol=_ztol(eltype(P1))))
+        prunefunc = (X -> removevredundancy!(X; ztol=_ztol(N)))
     end
     prunefunc(Pint)
 
     if isempty(Pint)
-        N = promote_type(eltype(P1), eltype(P2))
         return EmptySet{N}(n)
     end
     return VPolytope(Pint)

diff --git a/src/Sets/HPolytope.jl b/src/Sets/HPolytope.jl
@@ -225,8 +225,7 @@ backend; for the default backend used in `LazySets` see
 backends see
 [Polyhedra's documentation](https://juliapolyhedra.github.io/Polyhedra.jl/).
 """
-function vertices_list(P::HPolytope;
-                       backend=nothing, prune::Bool=true)
+function vertices_list(P::HPolytope; backend=nothing, prune::Bool=true)
     N = eltype(P)
     if isempty(P.constraints)
         return Vector{N}(Vector{N}(undef, 0))  # illegal polytope

diff --git a/src/Sets/VPolytope.jl b/src/Sets/VPolytope.jl
@@ -477,12 +477,13 @@ function remove_redundant_vertices(P::VPolytope{N};
     Q = polyhedron(P; backend=backend)
     if Polyhedra.supportssolver(typeof(Q))
         if isnothing(solver)
-            solver = default_lp_solver_polyhedra(N)
+            # presolver prints warnings about infeasible solutions (#3226)
+            solver = default_lp_solver_polyhedra(N; presolve=false)
         end
         vQ = Polyhedra.vrep(Q)
         Polyhedra.setvrep!(Q, Polyhedra.removevredundancy(vQ, solver))
     else
-        Polyhedra.removevredundancy!(Q; ztol=_ztol(N))
+        removevredundancy!(Q; ztol=_ztol(N))
     end
     return VPolytope(Q)
 end