Skip to content

Commit

Permalink
typo and docs tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
mforets committed Feb 28, 2018
1 parent c9a0f34 commit 35eef84
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions src/LineSegment.jl
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ true
```
We can check the intersection with another line segment, and optionally compute
a witness (that reduces to the common point in this case):
a witness (which is just the common point in this case):
```jldoctest linesegment_constructor
julia> sn = LineSegment([1., 0], [0., 1.])
Expand Down Expand Up @@ -123,8 +123,8 @@ Check whether a given point is contained in a line segment.
Let ``L = (p, q)`` be the line segment with extremes ``p`` and ``q``, and let
``x`` be the given point.
1. A necessary conidition for ``x ∈ (p, q)`` is that they are aligned, thus
their cross product should be zero.
1. A necessary condition for ``x ∈ (p, q)`` is that the three points are aligned,
thus their cross product should be zero.
2. It remains to check that ``x`` belongs to the box approximation of ``L``.
This amounts to comparing each coordinate with those of the extremes ``p``
and ``q``.
Expand Down
4 changes: 2 additions & 2 deletions src/is_intersection_empty.jl
Original file line number Diff line number Diff line change
Expand Up @@ -444,8 +444,8 @@ compute a witness.
### Algorithm
The algorithm is inspired from [here](https://stackoverflow.com/a/565282), which
again is the special 2D case of a 3D algorithm by R. Goldman, *Intersection of
two lines in three-space*, 1990.
again is the special 2D case of a 3D algorithm by Ronald Goldman's article on the
*Intersection of two lines in three-space* in Graphics Gems, Andrew S. (ed.), 1990.
We first check if the two line segments are parallel, and if so, if they are
collinear.
Expand Down

0 comments on commit 35eef84

Please sign in to comment.