Improve juliainfo #197
Merged
Improve juliainfo #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 496
💛 - Coveralls |
|
Rebased and fixed some issues. CIs are all green. It's good to go now. |
Closed
The standard error of julia is captured. It is bundled in CalledProcessError in case of non-zero exit code. In case of zero exit code, stderr is emits warning only if some message was written by julia.
Currently, startup file is not loaded in the main PyJulia session. Including the startup file has some potential problem. For example, if something is printed in the startup file then `juliainfo` would break. So it seems to be that the safe default is to avoid loading the startup file (though it makes sense to add an option to load it in the future).
tkf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements:
The original environment variables are used when launching
juliainfo. This makes it possible to calljuliainfoafter setting upcore.Julia. This should not happen when usingcore.Julianormally. However, some bugs may invokejuliainfoafter libjulia initialization. This PR does not fix such bug but at least make the error message less insane.Make
juliainfocallable even when PyCall.jl is not installed. This makes the failure less confusing; i.e., PyJulia fails whenusing PyCallis evaluated.The standard error of julia is captured. It is bundled in CalledProcessError in case of non-zero exit code. In case of zero exit code, stderr emits warning if some message was written by julia.
Currently, startup file is not loaded in the main PyJulia session. Including the startup file has some potential problem. For example, if something is printed in the startup file then
juliainfowould break. So it seems to be that the safe default is to avoid loading the startup file (though it makes sense to add an option to load it in the future).