Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve runtime path #187

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Resolve runtime path #187

merged 1 commit into from
Sep 10, 2018

Conversation

tkf
Copy link
Member

@tkf tkf commented Aug 19, 2018

#183 needs to go first. It's still a WIP as I need to update the docs. But I want to check that it works on other platforms first.

@tkf tkf force-pushed the runtime branch 2 times, most recently from e569622 to df1b468 Compare August 22, 2018 22:37
@stevengj
Copy link
Member

Good to go once docs are updated?

@tkf tkf changed the title WIP: Resolve runtime path Resolve runtime path Sep 5, 2018
@coveralls
Copy link

coveralls commented Sep 5, 2018

Pull Request Test Coverage Report for Build 471

  • 9 of 17 (52.94%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.7%) to 77.756%

Changes Missing Coverage Covered Lines Changed/Added Lines %
julia/core.py 9 17 52.94%
Files with Coverage Reduction New Missed Lines %
julia/find_libpython.py 4 78.15%
julia/core.py 8 83.54%
Totals Coverage Status
Change from base Build 469: -0.7%
Covered Lines: 395
Relevant Lines: 508

💛 - Coveralls

@tkf
Copy link
Member Author

tkf commented Sep 5, 2018

Rebased and added the docs. It's good to go now.

@tkf tkf mentioned this pull request Sep 6, 2018
@stevengj stevengj merged commit 65301c8 into JuliaPy:master Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants