-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix more 0.7 deprecations #505
Conversation
…lso define convert methods
… using local vars in at-cfunction
@tkelman, the failure on Travis/Linux with Julia 0.6 is somewhat mysterious to me. (The tests pass for me on my local machine.) Is there any way to get more test output? e.g. is it failing when precompiling? |
signal 9? maybe oom killed? try a debug build and ssh'ing in. and/or adding |
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
==========================================
+ Coverage 64.61% 65.58% +0.97%
==========================================
Files 18 18
Lines 1478 1485 +7
==========================================
+ Hits 955 974 +19
+ Misses 523 511 -12
Continue to review full report at Codecov.
|
…oved entirely for now, as it is unused)
Thanks for the suggestion @tkelman; doing a debug build means messing around with Travis authorization tokens, unfortunately, but I may have to resort to that if I can't figure out how to reproduce the problem offline. |
…e, but also define convert methods" This reverts commit 65cb003.
It looks like defining all the constructor methods explicitly was causing compilation resources to explode in 0.6... hopefully it is now fixed. |
No description provided.