Fix in-process symbol resolution #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've since re-arranged the way we load dynamic libraries a bit, making the current detection code ineffective. This should address most instances of pyjulia accidentally loading the wrong python version.
|
Looks good to me. |
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
=======================================
Coverage 66.04% 66.04%
=======================================
Files 17 17
Lines 1511 1511
=======================================
Hits 998 998
Misses 513 513
Continue to review full report at Codecov.
|
|
Any idea on Travis failure? |
|
One of them is a network timeout, the other is an error that I believe we've seen before on other packages and should be unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've since re-arranged the way we load dynamic libraries a bit, making
the current detection code ineffective. This should address most instances
of pyjulia accidentally loading the wrong python version.