-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conda install withenv #41
Conversation
I would think the copy should achieve the same thing, but hey if it works... |
|
||
Any environment variable starting by CONDA will interact with the run. | ||
""" | ||
function _set_conda_env(cmd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove this function and replace other uses of if with the same withenv
construct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if so, it's need to refactor with the newer function like run_with_env
.
run_with_env(`$conda install -y $pkg`)
run_with_env(`$conda remove -y $pkg`)
instead of
withenv(_get_conda_env()...) do
run(`$conda install -y $pkg`)
end
run(_set_conda_env(`$conda remove -y $pkg`))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, go for it! I just do not like to have two very similar functions with close names 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed something,
but it still needs the _set_conda_env
function for
that is used to get the information from the commands.
return collect(keys(JSON.parse(readstring(_set_conda_env(`$conda search $package --json`)))))
What is the issue with IJulia exactly? I am not sure I get the initial problem here. |
|
||
# install qt | ||
if is_windows() | ||
Conda.add("qt") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably clean up after itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added removing qt. thanks.
the issue is when installing qt with Conda on windows.
|
46df2c8
to
ee6fa26
Compare
I've checked this on Julia 0.5.0-rc3, so just close this PR soon, thanks |
I thought that was just a printing problem? |
I think that getting |
Oh, if the nightlies are from after the first was merged but before the second, then yes ENV will be wrong. |
closing. thanks. |
to fix the workaround on appveyor (CI for windows) of IJulia
https://github.com/JuliaLang/IJulia.jl/blob/master/appveyor.yml#L35
I have tested a bunch of times something like
the solution that I found is
withenv
, that works fine.it needs to know the details of the changes from Julia 0.4 and Julia 0.5
the global variable
ENV
and the functionsetenv
on windows.