Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update conda executable location for Linux/macOS #146

Closed
wants to merge 1 commit into from
Closed

update conda executable location for Linux/macOS #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Conda.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,11 @@ const conda = if Compat.Sys.iswindows()
conda_bat = joinpath(p, "conda.bat")
isfile(conda_bat) ? conda_bat : joinpath(p, "conda.exe")
else
joinpath(bin_dir(ROOTENV), "conda")
if haskey(ENV, "CONDA_EXE")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole if can be written as get(ENV, "CONDA_EXE", joinpath(bin_dir(ROOTENV), "conda")).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean solution, I am still quite new to Julia -- TIL!

You are right, CONDA_EXE is not documented in the quite obsolete user document, albeit being mentioned in release note.

However conda/conda#7126 (with detailed gitter chat record) might be quite evidential that $CONDA_EXE is considerably the de facto way to refer to conda executable after conda 4.4+...

ENV["CONDA_EXE"]
else
joinpath(bin_dir(ROOTENV), "conda")
end
end

"Path to the condarc file"
Expand Down