Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precompilation error for 1.6-DEV #34

Merged
merged 2 commits into from
Sep 27, 2020
Merged

Fix precompilation error for 1.6-DEV #34

merged 2 commits into from
Sep 27, 2020

Conversation

tkf
Copy link
Member

@tkf tkf commented Sep 27, 2020

Commit Message

Fix precompilation error for 1.6-DEV (#34)

This patch workarounds the change in Julia 1.6-DEV
JuliaLang/julia#37771
i.e., @doc SubModule "..." outside SubModule stopped working.

This patch avoids the precompilation error by simply inlining Extras
docstring.

@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #34 into master will increase coverage by 2.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   75.53%   77.86%   +2.33%     
==========================================
  Files           5        5              
  Lines         233      244      +11     
==========================================
+ Hits          176      190      +14     
+ Misses         57       54       -3     
Flag Coverage Δ
#unittests 77.86% <ø> (+2.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core.jl 94.73% <0.00%> (+0.29%) ⬆️
src/something.jl 97.05% <0.00%> (+0.39%) ⬆️
src/lift.jl 93.12% <0.00%> (+1.06%) ⬆️
src/extras.jl 88.88% <0.00%> (+12.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c977d80...7abbfec. Read the comment docs.

@tkf tkf marked this pull request as ready for review September 27, 2020 03:37
@mergify mergify bot merged commit 579f0d3 into master Sep 27, 2020
@mergify mergify bot deleted the fix-16dev branch September 27, 2020 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant