Show test pass at first frame #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes!!! So much yes!!! |
|
For the bigger space taken by expressions I'd rather fix the way the code is shown (eg single line blocks getting inlined) |
|
Nice! #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we always show the second-to-last frame as the default, until you move the timeline:
This makes sense for test failures, because probably the last function call went from computed results to
false, like a==call. But for test passes, it often just shows something trivial.This PR makes the first frame the default for test passes. This means that you can hide all code, and sort of quickly see what was being tested:
But as you see in the screenshot, a large test expression means that it takes up more vertical space...