This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
More efficient DefaultDict iteration #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 62.15% // Head: 61.75% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #121 +/- ##
==========================================
- Coverage 62.15% 61.75% -0.40%
==========================================
Files 10 10
Lines 539 536 -3
==========================================
- Hits 335 331 -4
- Misses 204 205 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
t-bltg
approved these changes
Oct 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current DefaultDict iteration is extremely expensive, mostly due to reliance on
Iterators.flatten. This change cuts many of these excessive allocations. See: JuliaPlots/Plots.jl#4237 (comment)Although it would be even better if we didn't have to preserve the order. Do we?
collect(union(x, y))is a bit more memory efficient, at the cost of lost order. But the current PR preserves exactly what the current code does.