Make @df support string column names #5033
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a special case to
add_sym!
to convert anAbstractString
column name to aSymbol
before adding it.The old behavior would iterate over the string and try to add each character as a column name. This produced a stack overflow, since
add_sym!
had no special case forChar
, resulting in indefinite recursion. More details in JuliaPlots/StatsPlots.jl#562.Attribution
Things to consider