Faster extrema calculations for large series #4412
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to type instability, the
expand_extrema
methods were very slow. Adding a type assert fixes that and greatly improves the performance of plotting large series.Test example:
Before:
1.004 s (19999416 allocations: 457.95 MiB)
After:
209.896 ms (4526 allocations: 152.85 MiB)
(Numbers both include the effect of an unmerged RecipesPipeline PR, but the impact is the same)