Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster extrema calculations for large series #4412

Merged
merged 3 commits into from
Oct 2, 2022

Conversation

BioTurboNick
Copy link
Member

@BioTurboNick BioTurboNick commented Oct 1, 2022

Due to type instability, the expand_extrema methods were very slow. Adding a type assert fixes that and greatly improves the performance of plotting large series.

Test example:

const x6 = rand(1000000, 10) # several large series
plot(x6);

Before: 1.004 s (19999416 allocations: 457.95 MiB)

After: 209.896 ms (4526 allocations: 152.85 MiB)

(Numbers both include the effect of an unmerged RecipesPipeline PR, but the impact is the same)

@t-bltg t-bltg added the performance speedups and slowdowns label Oct 1, 2022
@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Base: 80.87% // Head: 80.87% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (50a6df4) compared to base (539e5da).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4412   +/-   ##
=======================================
  Coverage   80.87%   80.87%           
=======================================
  Files          30       30           
  Lines        7439     7440    +1     
=======================================
+ Hits         6016     6017    +1     
  Misses       1423     1423           
Impacted Files Coverage Δ
src/axes.jl 86.13% <100.00%> (ø)
src/pipeline.jl 96.12% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@t-bltg t-bltg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@t-bltg t-bltg merged commit 644caa0 into JuliaPlots:master Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance speedups and slowdowns
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants