Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pgfplotsx.jl to use correct variable names #4348

Merged
merged 4 commits into from
Sep 15, 2022

Conversation

JamieMair
Copy link
Contributor

Should fix #4347

@BeastyBlacksmith
Copy link
Member

Would you mind adding a test for that?

@t-bltg
Copy link
Member

t-bltg commented Sep 15, 2022

Thanks for fixing, I probably induced this.
Should be covered indeed by a test in test/test_pgfplotsx.jl.

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 80.98% // Head: 80.98% // No change to project coverage 👍

Coverage data is based on head (a83e4bc) compared to base (610c384).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head a83e4bc differs from pull request most recent head ecebe4b. Consider uploading reports for the commit ecebe4b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4348   +/-   ##
=======================================
  Coverage   80.98%   80.98%           
=======================================
  Files          28       28           
  Lines        7340     7340           
=======================================
  Hits         5944     5944           
  Misses       1396     1396           
Impacted Files Coverage Δ
src/backends/pgfplotsx.jl 76.22% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JamieMair
Copy link
Contributor Author

Would you mind adding a test for that?

Should be added now. Not the best test, but fails without the fix.

@BeastyBlacksmith BeastyBlacksmith merged commit 065fd3c into JuliaPlots:master Sep 15, 2022
@BeastyBlacksmith
Copy link
Member

Thanks! You might want to checkout #3503

JamieMair added a commit to JamieMair/Plots.jl that referenced this pull request Sep 18, 2022
Added as suggested in JuliaPlots#4348.
@JamieMair JamieMair mentioned this pull request Sep 18, 2022
t-bltg added a commit that referenced this pull request Sep 19, 2022
Added as suggested in #4348.

Co-authored-by: t-bltg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] sp_width undefined for pgfplotsx backend when setting plot_titles
3 participants