Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include precompile_includer.jl #2839

Merged
merged 3 commits into from
Jul 2, 2020
Merged

include precompile_includer.jl #2839

merged 3 commits into from
Jul 2, 2020

Conversation

daschw
Copy link
Member

@daschw daschw commented Jul 2, 2020

See #2838

@aminya
Copy link
Contributor

aminya commented Jul 2, 2020

@daschw Could you edit this line instead to the following:
https://github.com/JuliaPlots/Plots.jl/blob/master/.github/workflows/SnoopCompile.yml#L77

((git diff -w --no-color) && (git diff -w --no-color | git apply --cached --ignore-whitespace && git checkout -- . && git reset && git add -p)) || echo done

Edit: this seems to not work. 🤔 For now, merge your PR as it is. Let me talk to GitHub about this, since it is a GitHub action issue.

@daschw
Copy link
Member Author

daschw commented Jul 2, 2020

ok, will do, thanks!

@aminya
Copy link
Contributor

aminya commented Jul 2, 2020

Let me know if the bot adds include("precompile_includer.jl") automatically.

@aminya
Copy link
Contributor

aminya commented Jul 2, 2020

@daschw I have decided to write a Julia script instead of a Bash script. So if this failed, please remove this line altogether or include the file manually, until I make a PR.

@daschw
Copy link
Member Author

daschw commented Jul 2, 2020

OK, thanks

@daschw daschw merged commit 079152a into JuliaPlots:master Jul 2, 2020
@daschw daschw deleted the precompile branch September 1, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants