layouts fixed #2799
Merged
layouts fixed #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isentropic
commented
Jun 18, 2020
| @@ -1263,7 +1263,7 @@ function _update_min_padding!(sp::Subplot{PyPlotBackend}) | |||
| # optionally add the width of colorbar labels and colorbar to rightpad | |||
| if haskey(sp.attr, :cbar_ax) | |||
| bb = py_bbox(sp.attr[:cbar_handle]."ax"."get_yticklabels"()) | |||
| sp.attr[:cbar_width] = _cbar_width + width(bb) + (sp[:colorbar_title] == "" ? 0px : 30px) | |||
| sp.attr[:cbar_width] = width(bb) + (sp[:colorbar_title] == "" ? 0px : 30px) | |||
There was a problem hiding this comment.
_cbar_width is already contained in the bb
| r == 1 ? layout.minpad[2] : 0mm, | ||
| c == nc ? layout.minpad[3] : 0mm, | ||
| r == nr ? layout.minpad[4] : 0mm | ||
| c == 1 ? layout.minpad[1] : pad_left[c], |
There was a problem hiding this comment.
My best short explanation:
minimum padding should be propagated to all the children in the grid.
Additionally, perhaps I should add a clarifying comment that minimum_perimeter actually means minimum_padding. It took me a while to understand this. Should I?
BeastyBlacksmith
approved these changes
Jun 18, 2020
|
This is due to colorbars not having a consistent width nor rules for scaling. Theres always more than actually required padding added for colorbars. I do not think it is related to grid layouting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the yet highest
brain_power_used / lines_changedratio for me 😄Fixes:
#2783
#2237
#1947
#2695
Perhaps there were other issues reporting some misalignment.
Plots before:
layouts before improvement.pdf
Plots after:
layouts improved.pdf