-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New recipe: lens #2372
Merged
Merged
New recipe: lens #2372
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d231618
create recipe, add box and line
BeastyBlacksmith fc4683c
add subplot
BeastyBlacksmith 00f1fed
improve linking
BeastyBlacksmith b886207
add ghost subplot
BeastyBlacksmith 96978cf
draw line only if inset is in subplot
BeastyBlacksmith bf619ee
sp_bbox -> inset_bbox
BeastyBlacksmith 53fc342
better linking
BeastyBlacksmith fa4db31
add lens! shorthand
BeastyBlacksmith 4b9cfa4
apply keywords only to inset
BeastyBlacksmith e816895
check bbox type
BeastyBlacksmith 54aaf58
add lens example
BeastyBlacksmith 4de93dd
fix typo and stray *
BeastyBlacksmith ae065c9
move legend out of the plot
BeastyBlacksmith 4e2a60d
move lens example down
BeastyBlacksmith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised this works - it's the type recipe signature, which is usually just used for type conversions to vector. Should this not be a "user recipe" with a
@userplot
shorthand defined?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought, this is the signature of a plot recipe ( and a valid usecase )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also I would like to only define the
lens!
shorthand, sincelens
by itself doesn't make too much sense.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah you're right. I don't think they are used anywhere in the ecosystem, but I may be wrong (it lists MarginalHist as an example, but looking down on that page clearly shows that marginalhist is a "user recipe"). Defining a
lens!
shorthand makes sense - but I feel that calling it withseriestype
as done here feels unideomatic.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be a more ideomatic alternative? I don't bother too much to change this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the
lens!
shorthand? Sorry I have zero experience using plot recipesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, now I got it. You meant the way to call the recipe is unideomatic, I thought the implementation with using the
seriestype
. I will add thelens!
shorthand.