Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tagbot fix; new: getlevel, istreechild, isgalled #219

Merged
merged 18 commits into from
Nov 27, 2024
Merged

tagbot fix; new: getlevel, istreechild, isgalled #219

merged 18 commits into from
Nov 27, 2024

Conversation

cecileane
Copy link
Member

blob info stored in network's .partition field
better doc.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 99.13043% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/types.jl 94.44% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/auxiliary.jl 82.94% <100.00%> (+1.19%) ⬆️
src/compareNetworks.jl 99.32% <ø> (+11.48%) ⬆️
src/graph_components.jl 99.25% <100.00%> (+0.09%) ⬆️
src/types.jl 93.75% <94.44%> (+28.12%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@NathanKolbow NathanKolbow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I added a couple additional test cases for getlevel and isgalled (the tests pass) and made some other minor fixes, so I'll approve the PR and leave it for you to merge if my additions look good @cecileane

@cecileane cecileane merged commit f730187 into master Nov 27, 2024
6 checks passed
@cecileane cecileane deleted the minor branch November 27, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants