Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: when deleting a hybrid edge leads to simplification of parallel edges at hybrid with 2 children #207

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

cecileane
Copy link
Member

to fix this error:

julia> n = readTopology("(a:0.003,((#H3:0::0.003,(b:0.2,c:0.2)#H1:0.3::1):0.3,(#H1:0::0)#H3:0::0.997):0);");

julia> majorTree(n)
ERROR: node 5 has no minor parent

which occurs because after this:

PhyloNetworks.deletehybridedge!(n, n.edge[2])

node number 4, H1, is still marked as hybrid but only 1 parent (tree) edge. Originally, H1 had 2 parents and 2 children.

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e93501) 86.83% compared to head (1b781d9) 86.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   86.83%   86.79%   -0.05%     
==========================================
  Files          31       31              
  Lines       12623    12635      +12     
==========================================
+ Hits        10961    10966       +5     
- Misses       1662     1669       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cecileane cecileane merged commit f46226c into master Jan 6, 2024
6 of 7 checks passed
@cecileane cecileane deleted the bugfix branch January 6, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant