Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removedegree2nodes! : option to keep the root #181

Merged
merged 3 commits into from
Aug 10, 2022
Merged

removedegree2nodes! : option to keep the root #181

merged 3 commits into from
Aug 10, 2022

Conversation

cecileane
Copy link
Member

useful to clean-up gene trees simulated by PhyloCoalSimulations, with degree-2 nodes to map gene trees into the species network.

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #181 (fb8b5b0) into master (2cf465b) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
- Coverage   85.94%   85.92%   -0.03%     
==========================================
  Files          29       29              
  Lines       11850    11824      -26     
==========================================
- Hits        10185    10160      -25     
+ Misses       1665     1664       -1     
Impacted Files Coverage Δ
src/auxiliary.jl 90.00% <100.00%> (-0.34%) ⬇️
src/manipulateNet.jl 91.44% <100.00%> (+0.03%) ⬆️
src/phyLiNCoptimization.jl 94.30% <0.00%> (+0.13%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@crsl4
Copy link
Member

crsl4 commented Aug 9, 2022

Should I push the changes to the citation function to this PR? Not sure if it will be updated if I push to netcleanup branch. I can also create a new PR.

@cecileane
Copy link
Member Author

cecileane commented Aug 9, 2022

Yes, any commit pushed to this netcleanup branch will update the PR. All the tests and the documentation build will run again.

@crsl4
Copy link
Member

crsl4 commented Aug 9, 2022

OK! I will push in a few minutes!

@cecileane cecileane merged commit 42f2c18 into master Aug 10, 2022
@cecileane cecileane deleted the netcleanup branch August 10, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants