Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heap snapshot endpoint #12

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Add heap snapshot endpoint #12

merged 4 commits into from
Dec 8, 2022

Conversation

nickrobinson251
Copy link
Collaborator

Adds /heap_snapshot taking query param all_one (default all_one=false), which returns a .heapsnapshot file using the Profile.take_heap_snaphot functionality available in v1.9+ (JuliaLang/julia#46862, see also JuliaLang/julia#42286).

Adds minimal docs for now, will re-vamp the README with the recently added functionality in a follow-up PR.

- So heap snapshot can be tested
- Can be removed once v1.9 is latest Julia release
@coveralls
Copy link

coveralls commented Dec 8, 2022

Pull Request Test Coverage Report for Build 3648755788

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.6%) to 100.0%

Totals Coverage Status
Change from base Build 3641721439: 1.6%
Covered Lines: 132
Relevant Lines: 132

💛 - Coveralls

Copy link
Collaborator

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo; nice stuff!

@nickrobinson251 nickrobinson251 merged commit 98594fa into main Dec 8, 2022
@nickrobinson251 nickrobinson251 deleted the npr/heap-snapshot branch December 8, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants