integrate with LibUV #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
commented
Feb 3, 2021
Codecov Report
@@ Coverage Diff @@
## vc/request #26 +/- ##
=============================================
Coverage ? 57.58%
=============================================
Files ? 6
Lines ? 488
Branches ? 0
=============================================
Hits ? 281
Misses ? 207
Partials ? 0 Continue to review full report at Codecov.
|
vchuravy
commented
Feb 3, 2021
| end | ||
|
|
||
| function start_server(ch_port = Channel{Int}(1), port = default_port) | ||
| ctx = UCX.UCXContext() | ||
| worker = UCX.UCXWorker(ctx) | ||
| timer = Timer(0, interval=0.001) do t # 0.001 smallest interval |
There was a problem hiding this comment.
@vtjnash I originally passed 0.0001 which was rounded down to 0, therefore only firing the Timer once...
Also passing a malformed cb doesn't yield an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.