-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AbstractTrees Interface #72
Conversation
Co-authored-by: Johannes Blaschke <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 28.36% 33.67% +5.31%
==========================================
Files 4 5 +1
Lines 846 962 +116
==========================================
+ Hits 240 324 +84
- Misses 606 638 +32 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments from my side:
-
Sounds like a pretty good use case for a Pkg Extension: the tree functionality would only become automatically available when one loads both Hwloc and AbstractTrees in the same session. OTOH, AbstractTrees is very lightweight, e.g. doesn't have any dependencies, so it might be fine as is.
-
Needs documentation, at least an example of how to use it for the README.
All done @carstenbauer -- now using Pkg Extensions. And updated README. Should I merge? |
LGTM but since the README here contains the changes from PR #71 already I guess you should wait with merging until that one has landed. BTW, I found a typo in the README: "eccident" should be "accident". |
Yep. I'll wait for your approval on #71 and #72 and then merge both in that order
Fixed it! Thanks. |
I will merge this together with #71 in about 6 hours if there are no objections. |
It exposes an
AbstractTrees.jl
interface via theHwlocTreeNode
. Hwloc is already a tree, but it's not easy to use from Julia, so this makes things like tree traversal, and iteration, from Julia much easier.This a follow-up for: #71