Fix incorrect assertion in schedule! #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, this improves |
jpsamaroo
force-pushed
the
jps/task-in-cache-bug
branch
from
f262b7f
to
2ebb51b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had an assertion in
schedule!that a task being scheduled could not already have a cache result, as that seems counterintuitive. However, when an upstream task has thrown an error, downstream tasks are all eagerly tainted byset_failed!, which sets their cache value to theThunkFailedExceptionobject.This PR loosens that assertion to ignore errored tasks, and refines the non-erroring case to throw a
SchedulingExceptionto the task instead.