wolfSSL: Update to 5.7.2

[dantaras]

No description provided.

[giordano]

Thanks for your contribution!

[giordano]

SecTrustEvaluateWithError requires macOS 10.14, you should use that SDK instead of skipping macOS entirely 🙂

[dantaras]

How can I get it to use that version? Do you have an example?

[giordano]

And the windows error https://buildkite.com/julialang/yggdrasil/builds/13798#01926c26-02b0-4d93-ac29-084611c7bd56/667-952 looks like an error in the build system, which I haven't looked into, but doesn't sound impossible to fix

[giordano]

How can I get it to use that version? Do you have an example?

Yggdrasil/A/AMReX/build_tarballs.jl

Lines 16 to 17 in 46da732

	ArchiveSource("https://github.com/phracker/MacOSX-SDKs/releases/download/10.15/MacOSX10.14.sdk.tar.xz",
	"0f03869f72df8705b832910517b47dd5b79eb4e160512602f593ed243b28715f"),

Yggdrasil/A/AMReX/build_tarballs.jl

Lines 24 to 31 in 46da732

	if [[ "${target}" == x86_64-apple-darwin* ]]; then
	pushd ${WORKSPACE}/srcdir/MacOSX10.*.sdk
	rm -rf /opt/${target}/${target}/sys-root/System
	cp -ra usr/* "/opt/${target}/${target}/sys-root/usr/."
	cp -ra System "/opt/${target}/${target}/sys-root/."
	export MACOSX_DEPLOYMENT_TARGET=10.14
	popd
	fi

[dantaras]

Thanks, tried something different, still waiting to see if it worked.

[giordano]

1. You're matching also aarch64-apple-darwin, which doesn't have the same problem (we use the 11.0 SDK there)
2. it isn't sufficient to pretend to have the 10.14 SDK, you actually need to use it as suggested in wolfSSL: Update to 5.7.2 #9578 (comment) 🙂

Side node, export MACOSX_DEPLOYMENT_TARGET=10.14 is a nicer way to accomplish this, since our compiler wrappers read the MACOSX_DEPLOYMENT_TARGET env var, the way you do it the compiler gets duplicate and conflicting -mmacosx-version-min options.

[dantaras]

Thanks! Did that and it worked. Any chance we can merge this in without the Windows build?

[dantaras]

Trying something for the windows build now.

[dantaras]

This should be ready now.

[giordano]

Can you please upstream this patch so that we'll be able to drop it in the future? Thanks!

[dantaras]

Opened a PR here: wolfSSL/wolfssl#8068. It'll be a while until that's merged and released though.

[ViralBShah]

Off-topic:

@giordano It seems that we now require "Update to latest master" button to be hit before merging is allowed. Is that by design - since it probably increases the CI load a fair bit. Sorry to ask here, but I saw it on a couple of PRs (and it may have already been discussed somewhere I didn't see it).

[giordano]

Thanks for pointing it out, that was not intended, my mistake while I was reviewing branch protection settings, I disabled that.