-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libjulia] add or update 1.12-DEV, 1.11-DEV, 1.10 #8151
Conversation
@@ -31,7 +31,7 @@ function Pkg.Types.is_stdlib(uuid::Base.UUID, julia_version::VersionNumber) | |||
return false | |||
end | |||
|
|||
jllversion=v"1.10.8" | |||
jllversion=v"1.10.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 1.11? 1.12? It's not clear to me given that 1.10.8 already contained 1.11-dev... Huh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think at some point we gave up with this number and just kept bumping the patch version. Since it is only used as BuildDependency
there is no need for compat statements anyway.
Those packages that need a specific version just fix that exact version and that's about it.
604b0f7
to
ac228b0
Compare
macOS builds in Julia >= 1.10 failing now. Weird also mingw builds for Julia 1.6.3 and 1.7.0 ?!? Has something changed in that regard on Yggdrasil? Error is e.g.
Aha, libuv; and for 1.6.3 and 1.7.0 we don't specify a version for those. Let's see. |
Pushed a change which might or might not help 1.6 and 1.7 with mingw, by hardcoding JLL versions there, too. For darwin, I see these errors:
and then a bit later
Also this (harmless) warnings pops up a lot:
Harmless, but suggests a possible improvement in the Julia build system |
The |
Mingw builds working now. Darwin/macOS jobs still failing. @benlorenz Thanks for the hint about The
I wonder what's going on there? Both GNU |
Let's see if my patch from JuliaLang/julia#53437 does the job |
I'm not entirely sure, but it may be cctools, we use an old-ish version: Yggdrasil/0_RootFS/gcc_sources.jl Lines 158 to 164 in 7fc6b66
|
Chasing down sandbox:${WORKSPACE} # which nm
/opt/bin/x86_64-apple-darwin14-libgfortran3-cxx03/nm
sandbox:${WORKSPACE} # cat /opt/bin/x86_64-apple-darwin14-libgfortran3-cxx03/nm
#!/bin/bash
# This compiler wrapper script brought into existence by `generate_compiler_wrappers!()`
if [ "x${SUPER_VERBOSE}" = "x" ]; then
vrun() { "$@"; }
else
vrun() { echo -e "\e[96m$@\e[0m" >&2; "$@"; }
fi
ARGS=( "$@" )
PRE_FLAGS=()
POST_FLAGS=()
if [[ " ${ARGS[@]} " == *"-march="* ]]; then
echo "BinaryBuilder: Cannot force an architecture via -march" >&2
exit 1
fi
vrun ${CCACHE} /opt/x86_64-apple-darwin14/bin/x86_64-apple-darwin14-nm "${PRE_FLAGS[@]}" "${ARGS[@]}" "${POST_FLAGS[@]}"
sandbox:${WORKSPACE} # file /opt/x86_64-apple-darwin14/bin/x86_64-apple-darwin14-nm
/opt/x86_64-apple-darwin14/bin/x86_64-apple-darwin14-nm: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-musl-x86_64.so.1, with debug_info, not stripped
sandbox:${WORKSPACE} # strings /opt/x86_64-apple-darwin14/bin/x86_64-apple-darwin14-nm | fgrep -i cc
access
cctools-949.0.1
@(#)PROGRAM:ld PROJECT:cctools-949.0.1
malformed object (LC_VERSION_MIN_MACOSX is set but the LC_BUILD_VERSION load command is not for MACCATALYST)
malformed object (the two LC_BUILD_VERSION load commands are not for MACOS and MACCATALYST)
GCC: (Alpine 9.3.0) 9.3.0
access So yeah, cctools. |
But since we override |
Darwin patch helped. Now 1.10 builds again. but new errors on 1.11 (and 1.12, which at this point is still quite similar):
|
Try with |
Reading https://reviews.llvm.org/D129198, I think we might need to do the osx framework update dance to get these symbols (to 10.13 or newer, I think the default is 10.12 on x86_64). Not really sure in what form the compiler is supposed to deal with this but if I understand some related comments correct then this operator is defined in the headers but not in the libc++ for 10.12. Setting # macos 10.12 has aligned alloc in the header but not in libc++
# leading to linker errors
if [[ "${target}" == *x86_64-apple* ]]; then
CXXFLAGS=-fno-aligned-allocation
fi Not totally sure how this will affect the downstream packages, maybe the |
This prevents a race condition when building 'julia-cli-debug julia-cli-release' simultaneously (as we do for libjulia_jll, and also generally seems appropriate given what is done for all other source files. Motivated by JuliaPackaging/Yggdrasil#8151 so I'll first see if it works there. Closes #45002.
@benlorenz thanks that did the trick |
This prevents a race condition when building 'julia-cli-debug julia-cli-release' simultaneously (as we do for libjulia_jll, and also generally seems appropriate given what is done for all other source files. Motivated by JuliaPackaging/Yggdrasil#8151 so I'll first see if it works there. Closes #45002. (cherry picked from commit fee198b)
This prevents a race condition when building 'julia-cli-debug julia-cli-release' simultaneously (as we do for libjulia_jll, and also generally seems appropriate given what is done for all other source files. Motivated by JuliaPackaging/Yggdrasil#8151 so I'll first see if it works there. Closes #45002. (cherry picked from commit fee198b)
This prevents a race condition when building 'julia-cli-debug julia-cli-release' simultaneously (as we do for libjulia_jll, and also generally seems appropriate given what is done for all other source files. Motivated by JuliaPackaging/Yggdrasil#8151 so I'll first see if it works there. Closes #45002. (cherry picked from commit fee198b)
This prevents a race condition when building 'julia-cli-debug julia-cli-release' simultaneously (as we do for libjulia_jll, and also generally seems appropriate given what is done for all other source files. Motivated by JuliaPackaging/Yggdrasil#8151 so I'll first see if it works there. Closes JuliaLang#45002.
This prevents a race condition when building 'julia-cli-debug julia-cli-release' simultaneously (as we do for libjulia_jll, and also generally seems appropriate given what is done for all other source files. Motivated by JuliaPackaging/Yggdrasil#8151 so I'll first see if it works there. Closes JuliaLang#45002.
This prevents a race condition when building 'julia-cli-debug julia-cli-release' simultaneously (as we do for libjulia_jll, and also generally seems appropriate given what is done for all other source files. Motivated by JuliaPackaging/Yggdrasil#8151 so I'll first see if it works there. Closes JuliaLang#45002. (cherry picked from commit fee198b)
No description provided.